From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 29708 invoked by alias); 21 Mar 2011 20:11:13 -0000 Received: (qmail 29678 invoked by uid 22791); 21 Mar 2011 20:11:13 -0000 X-SWARE-Spam-Status: No, hits=-6.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 21 Mar 2011 20:11:06 +0000 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p2LKB5pW018920 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Mon, 21 Mar 2011 16:11:05 -0400 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id p2LKB4Ts005794; Mon, 21 Mar 2011 16:11:05 -0400 Received: from opsy.redhat.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id p2LKB3iN023029; Mon, 21 Mar 2011 16:11:04 -0400 Received: by opsy.redhat.com (Postfix, from userid 500) id A1FC0378491; Mon, 21 Mar 2011 14:11:03 -0600 (MDT) From: Tom Tromey To: Jan Kratochvil Cc: gdb-patches@sourceware.org Subject: Re: [patch 3/7] find_pc_partial_function new parameter References: <20110319211544.GD30867@host1.jankratochvil.net> Date: Mon, 21 Mar 2011 20:34:00 -0000 In-Reply-To: <20110319211544.GD30867@host1.jankratochvil.net> (Jan Kratochvil's message of "Sat, 19 Mar 2011 22:15:44 +0100") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-03/txt/msg00972.txt.bz2 >>>>> "Jan" == Jan Kratochvil writes: Jan> find_pc_partial_function is heavily called inside GDB, therefore I Jan> did not change its prototype and provided Jan> find_pc_partial_function_gnu_ifunc instead. Jan> While I have no problem with changing all the callers it means passing Jan> everywhere the unused additional NULL parameter which may not be a win. This approach is fine. It is already used in many places in GDB. This patch looked fine to me. Tom