From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 7178 invoked by alias); 7 Apr 2011 17:04:57 -0000 Received: (qmail 7166 invoked by uid 22791); 7 Apr 2011 17:04:55 -0000 X-SWARE-Spam-Status: No, hits=-6.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 07 Apr 2011 17:04:47 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p37H4d1m010484 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Thu, 7 Apr 2011 13:04:39 -0400 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id p37H4cmQ026230; Thu, 7 Apr 2011 13:04:38 -0400 Received: from opsy.redhat.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id p37H4bwa000730; Thu, 7 Apr 2011 13:04:38 -0400 Received: by opsy.redhat.com (Postfix, from userid 500) id 4C1F837848E; Thu, 7 Apr 2011 11:04:37 -0600 (MDT) From: Tom Tromey To: Yao Qi Cc: Sergio Durigan Junior , gdb-patches@sourceware.org Subject: Re: [PATCH 4/6] Implement support for SystemTap probes References: <4D9D243A.3090505@codesourcery.com> Date: Thu, 07 Apr 2011 17:04:00 -0000 In-Reply-To: <4D9D243A.3090505@codesourcery.com> (Yao Qi's message of "Thu, 07 Apr 2011 10:40:58 +0800") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-04/txt/msg00111.txt.bz2 >>>>> "Yao" == Yao Qi writes: >> + pc_probe = find_probe_by_pc (pc, &objfile); Yao> I don't understand this part. We are looking for probe by matching Yao> frame's PC here, but address of stap_probe is the address where the Yao> probe is inserted. So, probably, we can't find any probe here, is that Yao> correct? I believe that the frame PC here actually is the location of the probe. Is there a situation where this would not be the case? stap-probe.exp specifically checks this code, by evaluating probe arguments at a probe point. Tom