From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-80327-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 17655 invoked by alias); 14 Apr 2011 20:31:57 -0000
Received: (qmail 17646 invoked by uid 22791); 14 Apr 2011 20:31:56 -0000
X-SWARE-Spam-Status: No, hits=-6.9 required=5.0	tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD
X-Spam-Check-By: sourceware.org
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 14 Apr 2011 20:31:51 +0000
Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23])	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p3EKVioA025591	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK);	Thu, 14 Apr 2011 16:31:45 -0400
Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199])	by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id p3EKVh7f019253;	Thu, 14 Apr 2011 16:31:43 -0400
Received: from opsy.redhat.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1])	by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id p3EKVfhP019714;	Thu, 14 Apr 2011 16:31:42 -0400
Received: by opsy.redhat.com (Postfix, from userid 500)	id BBFC937831C; Thu, 14 Apr 2011 14:31:41 -0600 (MDT)
From: Tom Tromey <tromey@redhat.com>
To: "Pierre Muller" <pierre.muller@ics-cnrs.unistra.fr>
Cc: <gdb-patches@sourceware.org>, "'Maxim Grigoriev'" <maxim@tensilica.com>
Subject: Re: [RFA] xtensa-tdep.c ARI fixes
References: <15837.6740910628$1302342165@news.gmane.org>
Date: Thu, 14 Apr 2011 20:31:00 -0000
In-Reply-To: <15837.6740910628$1302342165@news.gmane.org> (Pierre Muller's	message of "Sat, 9 Apr 2011 11:42:29 +0200")
Message-ID: <m34o60fuc2.fsf@fleche.redhat.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.2 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2011-04/txt/msg00209.txt.bz2

>>>>> "Pierre" == Pierre Muller <pierre.muller@ics-cnrs.unistra.fr> writes:

Pierre>   The only non-trivial change is in xtensa_register_type:
Pierre> this is mainly because I do not understand the old code:
Pierre> it was using both xmalloc and strdup, which should
Pierre> create a memory leak, no?
Pierre>   But maybe I miss something?

I agree.

Pierre> -		  char *name = xmalloc (16);
Pierre> +		  char *name = xstrprintf ("int%d", size * 8);

Looks better.

Pierre> +		    = arch_integer_type (gdbarch, size * 8, 1, name);

arch_integer_type calls arch_type, which calls xstrdup(name).
So I think you need to xfree name here.

Tom