From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 2072 invoked by alias); 10 May 2011 14:38:58 -0000 Received: (qmail 2016 invoked by uid 22791); 10 May 2011 14:38:57 -0000 X-SWARE-Spam-Status: No, hits=-6.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 10 May 2011 14:38:42 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p4AEcYWJ001760 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Tue, 10 May 2011 10:38:34 -0400 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id p4AEcYNF018985; Tue, 10 May 2011 10:38:34 -0400 Received: from opsy.redhat.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id p4AEcXgx007171; Tue, 10 May 2011 10:38:33 -0400 Received: by opsy.redhat.com (Postfix, from userid 500) id 3D69A3784CB; Tue, 10 May 2011 08:38:33 -0600 (MDT) From: Tom Tromey To: vanboxem.ruben@gmail.com Cc: gdb-patches@sourceware.org, mingw64 Subject: Re: [PATCH] 64-bit python support References: Date: Tue, 10 May 2011 14:38:00 -0000 In-Reply-To: (Ruben Van Boxem's message of "Tue, 10 May 2011 16:31:52 +0200") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-05/txt/msg00246.txt.bz2 >>>>> "Ruben" == Ruben Van Boxem writes: Ruben> Ah, I didn't know this, that's indeed very handy, but the two Ruben> occurrences in my patch are actually still a call to Py_InitModule Ruben> without the "4". Then that probably needs to be patched instead? No, there's a later define for that in modsupport.h: #define Py_InitModule(name, methods) \ Py_InitModule4(name, methods, (char *)NULL, (PyObject *)NULL, \ PYTHON_API_VERSION) I think the thing to do is track down why the Python headers are picking the wrong function name for you. Tom