From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-81296-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 28727 invoked by alias); 26 May 2011 16:24:08 -0000
Received: (qmail 28719 invoked by uid 22791); 26 May 2011 16:24:07 -0000
X-SWARE-Spam-Status: No, hits=-6.9 required=5.0	tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD
X-Spam-Check-By: sourceware.org
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 26 May 2011 16:23:45 +0000
Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11])	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p4QGNivr010142	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)	for <gdb-patches@sourceware.org>; Thu, 26 May 2011 12:23:44 -0400
Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199])	by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id p4QGNiIU002388;	Thu, 26 May 2011 12:23:44 -0400
Received: from opsy.redhat.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1])	by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id p4QGNhLe004312;	Thu, 26 May 2011 12:23:43 -0400
Received: by opsy.redhat.com (Postfix, from userid 500)	id 671C43781A7; Thu, 26 May 2011 10:23:43 -0600 (MDT)
From: Tom Tromey <tromey@redhat.com>
To: Marek Polacek <mpolacek@redhat.com>
Cc: "gdb-patches\@sourceware.org" <gdb-patches@sourceware.org>
Subject: Re: [PATCH] gdb.mi/mi-nonstop.exp: fix racy tests (PR testsuite/12649)
References: <4DD4F3B7.2070003@redhat.com>
Date: Thu, 26 May 2011 16:24:00 -0000
In-Reply-To: <4DD4F3B7.2070003@redhat.com> (Marek Polacek's message of "Thu,	19 May 2011 12:40:55 +0200")
Message-ID: <m34o4h1ldc.fsf@fleche.redhat.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.2 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2011-05/txt/msg00607.txt.bz2

>>>>> "Marek" == Marek Polacek <mpolacek@redhat.com> writes:

Marek> 2011-05-19  Marek Polacek  <mpolacek@redhat.com>
Marek>         * gdb.mi/mi-nonstop.exp: Use the send_gdb+gdb_expect or mi_gdb_test
Marek>         instead of the gdb_test_multiple.

Marek>  set supported 0
Marek> -gdb_test_multiple "-gdb-show non-stop" "" {
Marek> -    -re ".*\\^done,value=\"off\",supported=\"(\[^\"\]+)\"\r\n$mi_gdb_prompt$" {
Marek> +send_gdb "-gdb-show non-stop\n"
Marek> +gdb_expect {
Marek> +    -re "\\^done,value=\"off\",supported=\"(\[^\"\]+)\"\r\n$mi_gdb_prompt$" {
Marek>  	if { $expect_out(1,string) == "1" } {
Marek>  	    set supported 1
Marek>  	}
Marek>      }
Marek> +    -re "\\^done,value=\"off\"\r\n$mi_gdb_prompt$" {
Marek> +    }
Marek>      -re ".*$mi_gdb_prompt$" {
Marek> +	fail "-gdb-show non-stop"
Marek>      }
Marek>  }

It seems wrong to me to have a 'fail' without a corresponding 'pass'.

Marek> -gdb_test_multiple "-exec-interrupt --thread 1" "interrupted" {
Marek> +send_gdb "-exec-interrupt --thread 1\n"
Marek> +gdb_expect {
Marek>      -re "\\^done\r\n$mi_gdb_prompt\\*stopped\[^\r\n\]+\r\n$" {
Marek>  	pass "interrupted"
Marek>      }
Marek>  }

And likewise a pass without a fail.

Tom