From: Tom Tromey <tromey@redhat.com>
To: Jan Kratochvil <jan.kratochvil@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [patch 0/2] physname reg.: C++ breakpoints / linespec fixes
Date: Tue, 07 Jun 2011 20:24:00 -0000 [thread overview]
Message-ID: <m34o41fl0m.fsf@fleche.redhat.com> (raw)
In-Reply-To: <20110605202615.GA20427@host1.jankratochvil.net> (Jan Kratochvil's message of "Sun, 5 Jun 2011 22:26:15 +0200")
>>>>> "Jan" == Jan Kratochvil <jan.kratochvil@redhat.com> writes:
Jan> linespec is IMNSHO a hack anyway and one day it should be merged
Jan> with the general expression parser (used for example for `print');
Jan> which should be further merged with GCC/G++ parser. Expression
Jan> Parser Plug-In Available
Jan> http://sourceware.org/ml/archer/2011-q1/msg00122.html
I am not sure this is the right direction. I have a few issues with it.
First, it seems to me that we'll always have to keep some part of
linespecs around, because 'break file:line' is important. So, we'll
always have to look at the argument in multiple ways and decide what to
do.
Second, I suspect this ties linespecs too closely to the current language.
It seems reasonable to me for 'break ns::func()' to work in a C frame.
Third, IIRC your branch is based on the idea of the parser constructing
an expression, which is then decoded (or evalled?) to find the correct
symbol. I think this approach neglects the possibility that a linespec
could be ambiguous, another hot topic.
That said, I would welcome a detailed plan to redo linespec. Maybe
those objections are not very strong.
Tom
next prev parent reply other threads:[~2011-06-07 20:24 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-05 20:26 Jan Kratochvil
2011-06-05 20:58 ` Jan Kratochvil
2011-06-07 20:24 ` Tom Tromey [this message]
2011-06-08 14:43 ` Jan Kratochvil
2011-06-09 13:47 ` Jan Kratochvil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m34o41fl0m.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=jan.kratochvil@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox