From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-82152-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 27158 invoked by alias); 7 Jul 2011 18:52:22 -0000
Received: (qmail 27150 invoked by uid 22791); 7 Jul 2011 18:52:22 -0000
X-SWARE-Spam-Status: No, hits=-6.8 required=5.0	tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,TW_BJ,T_RP_MATCHES_RCVD
X-Spam-Check-By: sourceware.org
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 07 Jul 2011 18:52:07 +0000
Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25])	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p67IpoNX002651	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK);	Thu, 7 Jul 2011 14:51:50 -0400
Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199])	by int-mx12.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id p67IpoJe025311;	Thu, 7 Jul 2011 14:51:50 -0400
Received: from barimba (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1])	by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id p67IplMu006975;	Thu, 7 Jul 2011 14:51:48 -0400
From: Tom Tromey <tromey@redhat.com>
To: Fawzi Mohamed <fawzi.mohamed@nokia.com>
Cc: gdb-patches@sourceware.org, ext Tristan Gingold <gingold@adacore.com>,        =?utf-8?B?QW5kcsOpIFDDtm5pdHo=?= <andre.poenitz@nokia.com>,        ext Jan Kratochvil <jan.kratochvil@redhat.com>
Subject: Re: [PATCH,gdb,Update5]: ensures that cie ptr of an fda is a cie
References: <F1900C4A-1C06-4F4B-9048-16C9A3F03765@nokia.com>	<m3aacsvgnd.fsf@fleche.redhat.com>	<0FC98010-6811-4715-BD3B-AE8B9221C7BF@nokia.com>	<20110706170323.GA28535@host1.jankratochvil.net>	<C29D3D87-52FA-4E67-929E-13A3B885E28E@nokia.com>
Date: Thu, 07 Jul 2011 19:38:00 -0000
In-Reply-To: <C29D3D87-52FA-4E67-929E-13A3B885E28E@nokia.com> (Fawzi Mohamed's	message of "Thu, 7 Jul 2011 20:46:55 +0200")
Message-ID: <m34o2xrkjg.fsf@fleche.redhat.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2011-07/txt/msg00247.txt.bz2

>>>>> "Fawzi" == Fawzi Mohamed <fawzi.mohamed@nokia.com> writes:

Fawzi> Clearly as soon as I sent it away I realized that I did not check
Fawzi> if the arguments of printf were null.

I appreciate your attention to detail, but I don't think these checks
are needed:

Fawzi> +	      warning (_("skipping .eh_frame info of %s: %s"),
Fawzi> +		       (objfile->name ? objfile->name : "*unknown*"),

objfile->name cannot be NULL.
This is assumed generally.

Fawzi> +		       (e.message ? e.message : ""));

Likewise for the exception.

Tom