From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10697 invoked by alias); 6 Oct 2011 13:51:35 -0000 Received: (qmail 10614 invoked by uid 22791); 6 Oct 2011 13:51:32 -0000 X-SWARE-Spam-Status: No, hits=-7.2 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 06 Oct 2011 13:51:12 +0000 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p96DpBP1031253 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Thu, 6 Oct 2011 09:51:11 -0400 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx12.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id p96DpBTW030721; Thu, 6 Oct 2011 09:51:11 -0400 Received: from barimba (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id p96DpAj0030792; Thu, 6 Oct 2011 09:51:10 -0400 From: Tom Tromey To: pmuldoon@redhat.com Cc: gdb-patches@sourceware.org Subject: Re: [python] [patch] PR 13624 References: Date: Thu, 06 Oct 2011 13:51:00 -0000 In-Reply-To: (Phil Muldoon's message of "Thu, 06 Oct 2011 13:49:25 +0100") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-10/txt/msg00157.txt.bz2 >>>>> "Phil" == Phil Muldoon writes: Phil> The patch address PR 13624 which noted that in some instances we were Phil> not catching GDB exceptions. I checked every function and I found two Phil> GDB cases, and one Python case. Phil> OK? Almost. Phil> + PyErr_SetString (PyExc_RuntimeError, Phil> + _("Inferior arguments must be provided in a tuple.")); I think this should use PyExc_TypeError. Phil> type = check_typedef (value_type (self_value->value)); This line should also be in the TRY_CATCH. valpy_int is also missing some exception handling around CHECK_TYPEDEF. Also is_intlike has to be dealt with somehow (maybe by removing the CHECK_TYPEDEF and pushing it to the callers). valpy_float has an unprotected CHECK_TYPEDEF. valpy_lazy_string has an unprotected call to value_ind. valpy_get_is_optimized_out has an unprotected call to value_optimized_out; this one might not matter, but it is harmless to be defensive. Tom