From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-84310-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 1757 invoked by alias); 11 Oct 2011 17:07:01 -0000
Received: (qmail 1738 invoked by uid 22791); 11 Oct 2011 17:06:59 -0000
X-SWARE-Spam-Status: No, hits=-7.2 required=5.0	tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD,SPF_HELO_PASS
X-Spam-Check-By: sourceware.org
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 11 Oct 2011 17:06:29 +0000
Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23])	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p9BH6Jsp017358	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK);	Tue, 11 Oct 2011 13:06:19 -0400
Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199])	by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id p9BH6IcH028964;	Tue, 11 Oct 2011 13:06:19 -0400
Received: from barimba (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1])	by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id p9BH6HZg024275;	Tue, 11 Oct 2011 13:06:18 -0400
From: Tom Tromey <tromey@redhat.com>
To: Sterling Augustine <saugustine@google.com>
Cc: gdb-patches@sourceware.org
Subject: Re: Make DW_TAG_enumerator's consistent, regardless of containing scope
References: <CAEG7qUxckuOJJzDza6fHrajeNyr9bdd-jT22oQL85Dh0p-BN5w@mail.gmail.com>	<CAEG7qUyjapfjgBhYOVBxGmm04zrKfddtKk7Q34ob=W+z+Zoj_A@mail.gmail.com>
Date: Tue, 11 Oct 2011 17:07:00 -0000
In-Reply-To: <CAEG7qUyjapfjgBhYOVBxGmm04zrKfddtKk7Q34ob=W+z+Zoj_A@mail.gmail.com>	(Sterling Augustine's message of "Mon, 10 Oct 2011 15:20:44 -0700")
Message-ID: <m34nzfa25y.fsf@fleche.redhat.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2011-10/txt/msg00313.txt.bz2

>>>>> "Sterling" == Sterling Augustine <saugustine@google.com> writes:

Thanks.

Sterling> 2011-10-07  Sterling Augustine  <saugustine@google.com>
Sterling>        * dwarf2read.c (partial_die_parent_scope): Rearrange conditional logic.

I think this line needs to wrap.

Sterling> +if [get_compiler_info ${binfile} "c++"] {
Sterling> +    return -1
Sterling> +}

Does this really do anything?
(I don't know.)

Sterling> +gdb_exit
Sterling> +gdb_start
Sterling> +gdb_reinitialize_dir $srcdir/$subdir
Sterling> +gdb_load ${binfile}

This stanza can be replaced by clean_restart.

Tom