From: Tom Tromey <tromey@redhat.com>
To: Keith Seitz <keiths@redhat.com>
Cc: "gdb-patches\@sourceware.org ml" <gdb-patches@sourceware.org>
Subject: Re: [RFA] mi/10586
Date: Mon, 14 Nov 2011 20:28:00 -0000 [thread overview]
Message-ID: <m34ny6qwi9.fsf@fleche.redhat.com> (raw)
In-Reply-To: <4EC16BD8.90309@redhat.com> (Keith Seitz's message of "Mon, 14 Nov 2011 11:28:24 -0800")
>>>>> "Keith" == Keith Seitz <keiths@redhat.com> writes:
Keith> According to the documentation, -var-info-expression is supposed to
Keith> return a name of the variable/child which is to be presented to the
Keith> user. I don't think we want to present "0_anonymous". GCC uses
Keith> "<anonymous struct>", and that seems like a reasonable convention to
Keith> follow.
Actually, thinking about it more, it seems to me that it would be ok for
these cases to just be errors. There's no really good way to refer to
the anonymous field as its own entity, and I don't think we should hack
up the parser and whatever else to support this.
Keith> Clearly the two last elements dealing with 0_anonymous are
Keith> incorrect. I believe these should be:
Keith> -var-info-path-expression a.public.0_anonymous = ""
This one, I think should be an error.
Keith> -var-info-path-expression a.public.0_anonymous.b = "((a).b)"
But I agree about this one.
What do you think?
Tom
next prev parent reply other threads:[~2011-11-14 20:28 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-11 21:30 Keith Seitz
2011-11-14 15:45 ` Tom Tromey
2011-11-14 18:04 ` Keith Seitz
2011-11-14 18:18 ` Tom Tromey
2011-11-14 19:28 ` Keith Seitz
2011-11-14 20:28 ` Tom Tromey [this message]
2011-11-15 17:10 ` Keith Seitz
2011-11-15 17:30 ` Tom Tromey
2011-12-02 22:28 ` Keith Seitz
2011-12-13 1:28 ` Keith Seitz
2011-12-13 19:58 ` Tom Tromey
2011-12-17 1:55 ` Keith Seitz
2011-12-20 16:03 ` Tom Tromey
2012-01-12 23:05 ` Keith Seitz
2011-12-13 20:34 ` Crash regression with Eclipse [Re: [RFA] mi/10586] Jan Kratochvil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m34ny6qwi9.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=keiths@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox