From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 16490 invoked by alias); 30 Nov 2011 17:29:13 -0000 Received: (qmail 16472 invoked by uid 22791); 30 Nov 2011 17:29:12 -0000 X-SWARE-Spam-Status: No, hits=-7.6 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 30 Nov 2011 17:28:59 +0000 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id pAUHSujD031134 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Wed, 30 Nov 2011 12:28:56 -0500 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx12.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id pAUHStgK009068; Wed, 30 Nov 2011 12:28:56 -0500 Received: from barimba (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id pAUHSraD016653; Wed, 30 Nov 2011 12:28:54 -0500 From: Tom Tromey To: Pedro Alves Cc: gdb-patches@sourceware.org Subject: Re: [RFC/WIP PATCH 08/14] Add support for the '@' core operator References: <20111128153742.17761.21459.stgit@localhost6.localdomain6> <20111128153937.17761.6716.stgit@localhost6.localdomain6> Date: Wed, 30 Nov 2011 17:29:00 -0000 In-Reply-To: <20111128153937.17761.6716.stgit@localhost6.localdomain6> (Pedro Alves's message of "Mon, 28 Nov 2011 15:39:37 +0000") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.90 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-11/txt/msg00851.txt.bz2 >>>>> "Pedro" == Pedro Alves writes: Pedro> This adds support for the '@' operator as described in the series Pedro> description. I've left this split into a separate patch, as I have Pedro> tend to think the syntax for filtering per core will end up different. Pedro> In any case, this adds support for set intersection, so I went ahead Pedro> with it anyway. Just some trivia... Pedro> +/* Implementation of `contains_inferior' method. */ Pedro> + Pedro> +static int Pedro> +core_range_contains_thread (struct itset_elt *base, struct thread_info *thr) Comment mentions the wrong method. Pedro> +/* Implementation of `contains_inferior' method. */ Pedro> + Pedro> +static int Pedro> +intersect_contains_thread (struct itset_elt *base, struct thread_info *thr) Here too. Pedro> /* Implementation of `contains_inferior' method. */ Pedro> static int Pedro> -state_contains_inferior (struct itset_elt *base, struct inferior *inf) Pedro> +state_contains_thread (struct itset_elt *base, struct thread_info *thr) Here too. Tom