From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10215 invoked by alias); 20 Dec 2011 20:38:27 -0000 Received: (qmail 10204 invoked by uid 22791); 20 Dec 2011 20:38:26 -0000 X-SWARE-Spam-Status: No, hits=-5.5 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SINGLE_HEADER_1K,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 20 Dec 2011 20:38:09 +0000 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id pBKKc9VU013023 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Tue, 20 Dec 2011 15:38:09 -0500 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx12.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id pBKKc83h018241; Tue, 20 Dec 2011 15:38:08 -0500 Received: from barimba (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id pBKKc7aJ001334; Tue, 20 Dec 2011 15:38:07 -0500 From: Tom Tromey To: Kevin Pouget Cc: gdb-patches@sourceware.org Subject: Re: [RFC] Python Finish Breakpoints References: Date: Tue, 20 Dec 2011 20:55:00 -0000 In-Reply-To: (Kevin Pouget's message of "Fri, 9 Dec 2011 10:31:45 +0100") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.92 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-12/txt/msg00699.txt.bz2 >>>>> "Kevin" == Kevin Pouget writes: Kevin> 2011-12-09 Kevin Pouget Kevin> Introduce gdb.FinishBreakpoint in Python [...] One last little thing, in the test suite. Kevin> diff --git a/gdb/testsuite/gdb.python/py-finish-breakpoint.exp b/gdb/testsuite/gdb.python/py-finish-breakpoint.exp Kevin> +if $tracelevel then { Kevin> + strace $tracelevel Kevin> +} Here, this needs to check whether shlibs are ok, like: if {[skip_shlib_tests]} { untested $name.exp return -1 } Kevin> +# Start with a fresh gdb. Kevin> +clean_restart ${testfile} After clean_restart you need gdb_load_shlibs $lib_sl I think there are a few of these in this .exp file. I don't think you really needed shared libraries for this test, but now that you did it, it is fine. Patch ok with this fixed up. Thanks! Tom