From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 25344 invoked by alias); 4 Dec 2013 23:35:33 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 25335 invoked by uid 89); 4 Dec 2013 23:35:33 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_50,RDNS_NONE,SPF_HELO_PASS,SPF_PASS autolearn=no version=3.3.2 X-HELO: mx1.redhat.com Received: from Unknown (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 04 Dec 2013 23:35:32 +0000 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id rB4NZK7M014335 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Wed, 4 Dec 2013 18:35:20 -0500 Received: from psique (ovpn-113-192.phx2.redhat.com [10.3.113.192]) by int-mx12.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id rB4NZH1u013115 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Wed, 4 Dec 2013 18:35:19 -0500 From: Sergio Durigan Junior To: Tom Tromey Cc: Marcus Shawcroft , Marcus Shawcroft , GDB Patches Subject: Re: [PATCH] Fix for PR tdep/15653: Implement SystemTap SDT probe support for AArch64 References: <1385336092-19621-1-git-send-email-sergiodj@redhat.com> <52931DB7.6030205@arm.com> <87siuh21zr.fsf@fleche.redhat.com> X-URL: http://www.redhat.com Date: Wed, 04 Dec 2013 23:35:00 -0000 In-Reply-To: <87siuh21zr.fsf@fleche.redhat.com> (Tom Tromey's message of "Wed, 27 Nov 2013 10:22:48 -0700") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-IsSubscribed: yes X-SW-Source: 2013-12/txt/msg00162.txt.bz2 On Wednesday, November 27 2013, Tom Tromey wrote: >>>>>> "Marcus" == Marcus Shawcroft writes: > > Marcus> Sorry, I was not clear. I think the a64 and a32 parsers should be kept > Marcus> separate rather than using a common parser for a different, but > Marcus> similar syntax, thus avoiding the need to pass the flag that > Marcus> distinguishes the different syntaxes. > > It seems reasonable to me. > It looks to me like the current function arm_stap_parse_special_token is > the only code shared by the patch. That isn't so long by itself, and > then if it needs tweaks for AArch64 -- one might as well just copy it. Sorry for taking a long time to reply. OK then, two voices against one, you win :-). I will repost the AArch64 patch later without this specific part, i.e., replicating the code from ARM. -- Sergio