From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 89629 invoked by alias); 15 Aug 2015 06:21:07 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 89620 invoked by uid 89); 15 Aug 2015 06:21:06 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.8 required=5.0 tests=AWL,BAYES_00,FREEMAIL_ENVFROM_END_DIGIT,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-pa0-f41.google.com Received: from mail-pa0-f41.google.com (HELO mail-pa0-f41.google.com) (209.85.220.41) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Sat, 15 Aug 2015 06:21:05 +0000 Received: by pacgr6 with SMTP id gr6so73043131pac.2 for ; Fri, 14 Aug 2015 23:21:03 -0700 (PDT) X-Received: by 10.69.14.227 with SMTP id fj3mr5836243pbd.144.1439619663354; Fri, 14 Aug 2015 23:21:03 -0700 (PDT) Received: from seba.sebabeach.org.gmail.com (173-13-178-53-sfba.hfc.comcastbusiness.net. [173.13.178.53]) by smtp.gmail.com with ESMTPSA id bh3sm7881431pbb.59.2015.08.14.23.21.02 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 14 Aug 2015 23:21:02 -0700 (PDT) From: Doug Evans To: Pierre-Marie de Rodat Cc: Kevin Buettner , gdb-patches@sourceware.org Subject: Re: [PATCH] Add proper handling for non-local references in nested functions References: <54F47563.4050103@adacore.com> <54FF0D05.70907@redhat.com> <550C1170.9070208@adacore.com> <55685B60.3000004@redhat.com> <55775EB0.4080701@adacore.com> <55AF5F7E.5000600@adacore.com> <20150722173957.7ed51f18@pinnacle.lan> <55B0C583.6050601@adacore.com> <55BB538B.7090104@adacore.com> Date: Sat, 15 Aug 2015 06:21:00 -0000 In-Reply-To: (Doug Evans's message of "Fri, 14 Aug 2015 22:08:30 -0700") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-IsSubscribed: yes X-SW-Source: 2015-08/txt/msg00401.txt.bz2 Doug Evans writes: > Hi. > Just a couple of nits. > Ok with them fixed (not sure what the right fix for the first one is > though, I could be missing something). > grep for ^==== > > Also, I found a 4% performance degradation in a couple of gmonster > perf tests (e.g., gmonster2-ptype-string.exp). > Not enough to reject the patch, but it would be interesting > to find the culprit (assuming it's not a test issue!). If you want to see if you can see the 4% regression too, I've updated the wiki with some instructions to get one using the perf testsuite (hopefully) quickly: https://sourceware.org/gdb/wiki/GDBPerfTestsuite You have to be patient with the build, these are big programs. bash$ sh buildperf.sh Here are a couple of my results: Before (trunk): bash$ sh runperf.sh bash$ cat perftest.sum gmonster1:gmonster-pervasive-typedef cpu_time 10-cus 0.007923 gmonster1:gmonster-pervasive-typedef cpu_time 100-cus 0.061346 gmonster1:gmonster-pervasive-typedef cpu_time 1000-cus 0.7087322 gmonster1:gmonster-pervasive-typedef cpu_time 10000-cus 7.6932424 gmonster1:gmonster-pervasive-typedef wall_time 10-cus 0.00795402526855 gmonster1:gmonster-pervasive-typedef wall_time 100-cus 0.061425447464 gmonster1:gmonster-pervasive-typedef wall_time 1000-cus 0.709506464005 gmonster1:gmonster-pervasive-typedef wall_time 10000-cus 7.70150403976 gmonster1:gmonster-pervasive-typedef vmsize 10-cus 110600 gmonster1:gmonster-pervasive-typedef vmsize 100-cus 119276 gmonster1:gmonster-pervasive-typedef vmsize 1000-cus 206218 gmonster1:gmonster-pervasive-typedef vmsize 10000-cus 1079663 gmonster2:gmonster-ptype-string cpu_time 10-sos 0.2961394 gmonster2:gmonster-ptype-string cpu_time 100-sos 1.5917764 gmonster2:gmonster-ptype-string cpu_time 1000-sos 20.6852 gmonster2:gmonster-ptype-string wall_time 10-sos 0.296435832977 gmonster2:gmonster-ptype-string wall_time 100-sos 1.5934440136 gmonster2:gmonster-ptype-string wall_time 1000-sos 20.7090939522 gmonster2:gmonster-ptype-string vmsize 10-sos 283208 gmonster2:gmonster-ptype-string vmsize 100-sos 702776 gmonster2:gmonster-ptype-string vmsize 1000-sos 4908408 After (trunk + patch): bash$ sh runperf.sh bash$ cat perftest.sum gmonster1:gmonster-pervasive-typedef cpu_time 10-cus 0.0077614 gmonster1:gmonster-pervasive-typedef cpu_time 100-cus 0.063923 gmonster1:gmonster-pervasive-typedef cpu_time 1000-cus 0.7615324 gmonster1:gmonster-pervasive-typedef cpu_time 10000-cus 7.898073 gmonster1:gmonster-pervasive-typedef wall_time 10-cus 0.00778799057007 gmonster1:gmonster-pervasive-typedef wall_time 100-cus 0.0640145301819 gmonster1:gmonster-pervasive-typedef wall_time 1000-cus 0.762880802155 gmonster1:gmonster-pervasive-typedef wall_time 10000-cus 7.90763082504 gmonster1:gmonster-pervasive-typedef vmsize 10-cus 108520 gmonster1:gmonster-pervasive-typedef vmsize 100-cus 117200 gmonster1:gmonster-pervasive-typedef vmsize 1000-cus 204180 gmonster1:gmonster-pervasive-typedef vmsize 10000-cus 1077580 gmonster2:gmonster-ptype-string cpu_time 10-sos 0.3188818 gmonster2:gmonster-ptype-string cpu_time 100-sos 1.7196954 gmonster2:gmonster-ptype-string cpu_time 1000-sos 21.5444378 gmonster2:gmonster-ptype-string wall_time 10-sos 0.319199228287 gmonster2:gmonster-ptype-string wall_time 100-sos 1.72196946144 gmonster2:gmonster-ptype-string wall_time 1000-sos 21.5659247875 gmonster2:gmonster-ptype-string vmsize 10-sos 281128 gmonster2:gmonster-ptype-string vmsize 100-sos 700628 gmonster2:gmonster-ptype-string vmsize 1000-sos 4906312 3-4% isn't much, but I wouldn't have expected any slowdown. I haven't ruled out the problem is elsewhere and not with the patch, but I have repeated the results a couple of times, so at least it's consistent. :-)