Re: Cell multi-arch broken (Re: [PATCH 2/2] GNU/Linux: Stop using libthread_db/td_ta_thr_iter)

Ulrich Weigand
2015-08-27T17:40:16Z

Pedro Alves wrote:
> On 08/26/2015 08:01 PM, Ulrich Weigand wrote:
> > Pedro Alves wrote:
>
> >> (Sounds like the testsuite could be improved to better detect this.)
> >
> > Yes, I think I'll at least set the test case to UNRESOLVED if
> > something unexpected happens while attempting to detect whether
> > we have Cell/B.E. hardware.
>
> Sounds good to me.

I've pushed the testcase change (see patch below) ...

> >> find_one_thread makes use of td_ta_map_lwp2thr for the
> >> mapping we're after.
> >> On the GDB side, the equivalent is linux-thread-db.c:thread_from_lwp.
> >
> > Ah, indeed that works for me. The attached patch also fixes the
> > problem for me.
> >
>
> LGTM.

... and this linux-thread-db fix now.

Thanks,
Ulrich

testsuite/ChangeLog:

* lib/cell.exp (skip_cell_tests): Report UNRESOLVED on unexpected
failures to run the test program under GDB.

Index: binutils-gdb/gdb/testsuite/lib/cell.exp
===================================================================
--- binutils-gdb.orig/gdb/testsuite/lib/cell.exp
+++ binutils-gdb/gdb/testsuite/lib/cell.exp
@@ -139,7 +139,7 @@ gdb_caching_proc skip_cell_tests {
set result 1
}
default {
- verbose -log "\n$me Cell/B.E. hardware not detected (default case)"
+ unresolved "$me: unexpected failure"
set result 1
}
}

--
Dr. Ulrich Weigand
GNU/Linux compilers and toolchain
Ulrich.Weigand@de.ibm.com