Re: [RFA] win32-nat.c: Simplify generation of Windows environment

Jim Blandy
2006-12-09T08:01:12Z

Eli Zaretskii <eliz@gnu.org> writes:
>> Cc: gdb-patches@sourceware.org
>> From: Jim Blandy <jimb@codesourcery.com>
>> Date: Thu, 07 Dec 2006 16:10:14 -0800
>>
>> $ cd gdb/config
>> $ grep -nH -e win32-nat */*.m?
>> i386/cygwin.mh:2:NATDEPFILES= i386-nat.o win32-nat.o corelow.o
>> $
>>
>> I think that means it's just Cygwin.
>
> No, it just means that the native W32 build is currently not part of
> the CVS.
>
> A large portion of win32-nat.c is relevant to any native Windows
> debugger. By contrast, cygwin_internal is obviously Cygwin-specific.
> So I think it would be a good practice to mark such specific portions
> of code explicitly.

Given what I've read so far, I don't agree. In general, for the
intents and purposes of the Project GNU debugger, win32-nat.c is
Cygwin-specific. If someone is maintaining out-of-tree W32 patches,
then it is up to them to amend those patches to add the sort of
#ifdefs you suggest. It's not reasonable to expect contributors to
the the public GDB sources to anticipate and accomodate the needs of
code they can't see.

But that's "in general". If there's a further story here that can be
told where some minor effort on our part will make it easier for
someone to participate and contribute to GDB, then I think folks here
are pretty friendly and would be willing to listen.