Re: [RFA] win32-nat.c: Simplify generation of Windows environment

Christopher Faylor
2006-12-08T20:43:47Z

Sorry for the delay in responding. I'm on a business trip this week.

On Thu, Dec 07, 2006 at 11:37:02PM +0200, Eli Zaretskii wrote:
>> Date: Thu, 7 Dec 2006 10:58:39 +0100
>> From: Corinna Vinschen <vinschen@redhat.com>
>>
>> the below patch simplifies the code which translates the Cygwin
>> environment into the native Windows environment. So far this is
>> done in GDB manually. However, there's a Cygwin specific function
>> call which does the same for the calling process. Using this call
>> has three advantages.
>
>Is win32-nat.c used only for the Cygwin build? I thought the native
>Windows build used it as well (perhaps with a few patches that are not
>yet part of the CVS), but maybe I was mistaken.
>
>If I am right, then please make this change, and especially the call
>to cygwin_internal, conditioned on __CYGWIN__, or some other
>Cygwin-specific symbol.

There is no need for an ifdef.

% grep -C 2 cygwin_internal win32-nat.c
{
/* Try fall back to Cygwin pid */
pid = cygwin_internal (CW_CYGWIN_PID_TO_WINPID, pid);

if (pid > 0)
--
struct external_pinfo *pinfo;

cygwin_internal (CW_LOCK_PINFO, 1000);
for (cpid = 0;
(pinfo = (struct external_pinfo *)
cygwin_internal (CW_GETPINFO, cpid | CW_NEXTPID));
cpid = pinfo->pid)
{
--
}
}
cygwin_internal (CW_UNLOCK_PINFO);
return path_ptr;
}

Corinna, please go ahead and check in your patch.

cgf