Re: [RFA] win32-nat.c: Simplify generation of Windows environment

Jim Blandy
2006-12-07T19:48:41Z

Corinna Vinschen <vinschen@redhat.com> writes:
> the below patch simplifies the code which translates the Cygwin
> environment into the native Windows environment. So far this is
> done in GDB manually. However, there's a Cygwin specific function
> call which does the same for the calling process. Using this call
> has three advantages.
>
> - We can drop a rather big chunk of code from GDB which should be the
> task of Cygwin anyway.
> - By using the Cygwin method of converting the environment, we take
> care of all environment variables which have to be converted in
> some way; not only the PATH variable, but all variables which are
> also translated by Cygwin, thus making this process more transparent.
> - Subsequent changes in Cygwin don't require to change GDB.
>
>
> Ok to apply?

I'm very much inclined to take your advice on Cygwin-related issues,
and I love the deletion of code, but I still have some questions:

Is it really okay to call cygwin_internal? (That's not the name I'd
expect a public, stable interface to have.)

How well will this work on older versions of Cygwin? Will people
still be able to compile GDB against the Cygwin versions they can now?