From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 30102 invoked by alias); 7 Dec 2006 19:48:41 -0000 Received: (qmail 30089 invoked by uid 22791); 7 Dec 2006 19:48:41 -0000 X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (65.74.133.4) by sourceware.org (qpsmtpd/0.31) with ESMTP; Thu, 07 Dec 2006 19:48:35 +0000 Received: (qmail 6366 invoked from network); 7 Dec 2006 19:48:33 -0000 Received: from unknown (HELO localhost) (jimb@127.0.0.2) by mail.codesourcery.com with ESMTPA; 7 Dec 2006 19:48:33 -0000 To: gdb-patches@sourceware.org Subject: Re: [RFA] win32-nat.c: Simplify generation of Windows environment References: <20061207095839.GA14487@calimero.vinschen.de> From: Jim Blandy Date: Thu, 07 Dec 2006 19:48:00 -0000 In-Reply-To: <20061207095839.GA14487@calimero.vinschen.de> (Corinna Vinschen's message of "Thu, 7 Dec 2006 10:58:39 +0100") Message-ID: User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2006-12/txt/msg00102.txt.bz2 Corinna Vinschen writes: > the below patch simplifies the code which translates the Cygwin > environment into the native Windows environment. So far this is > done in GDB manually. However, there's a Cygwin specific function > call which does the same for the calling process. Using this call > has three advantages. > > - We can drop a rather big chunk of code from GDB which should be the > task of Cygwin anyway. > - By using the Cygwin method of converting the environment, we take > care of all environment variables which have to be converted in > some way; not only the PATH variable, but all variables which are > also translated by Cygwin, thus making this process more transparent. > - Subsequent changes in Cygwin don't require to change GDB. > > > Ok to apply? I'm very much inclined to take your advice on Cygwin-related issues, and I love the deletion of code, but I still have some questions: Is it really okay to call cygwin_internal? (That's not the name I'd expect a public, stable interface to have.) How well will this work on older versions of Cygwin? Will people still be able to compile GDB against the Cygwin versions they can now?