From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 22713 invoked by alias); 5 Dec 2007 21:34:33 -0000 Received: (qmail 22705 invoked by uid 22791); 5 Dec 2007 21:34:33 -0000 X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (65.74.133.4) by sourceware.org (qpsmtpd/0.31) with ESMTP; Wed, 05 Dec 2007 21:34:27 +0000 Received: (qmail 18575 invoked from network); 5 Dec 2007 21:34:25 -0000 Received: from unknown (HELO localhost) (jimb@127.0.0.2) by mail.codesourcery.com with ESMTPA; 5 Dec 2007 21:34:25 -0000 To: gdb-patches@sourceware.org Subject: Re: [RFA] Ignore breakpoints when reading memory. References: <200712011419.45773.vladimir@codesourcery.com> <20071204192201.GA24515@caradoc.them.org> From: Jim Blandy Date: Wed, 05 Dec 2007 22:31:00 -0000 In-Reply-To: <20071204192201.GA24515@caradoc.them.org> (Daniel Jacobowitz's message of "Tue, 4 Dec 2007 14:22:01 -0500") Message-ID: User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-12/txt/msg00092.txt.bz2 Daniel Jacobowitz writes: > On Sat, Dec 01, 2007 at 02:19:45PM +0300, Vladimir Prus wrote: >> >> This commit prepares us for always-inserted-breakpoints mode. >> If breakpoints are always inserted, then reading the code memory >> will read the breakpoint instructions, not the original content. >> This patch makes us try to restore the original comments using >> the breakpoints table. OK? > > Doesn't this make the extra call in read_memory_nobpt redundant? > > Are there any sites that need to see the breakpoint? For instance, > look at ppc_linux_memory_remove_breakpoint. The code I'm presently working on would like to see breakpoints, to my surprise.