From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 16176 invoked by alias); 4 Jun 2009 22:05:22 -0000 Received: (qmail 16157 invoked by uid 22791); 4 Jun 2009 22:05:18 -0000 X-SWARE-Spam-Status: No, hits=-2.3 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mx2.redhat.com (HELO mx2.redhat.com) (66.187.237.31) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 04 Jun 2009 22:05:13 +0000 Received: from int-mx2.corp.redhat.com (int-mx2.corp.redhat.com [172.16.27.26]) by mx2.redhat.com (8.13.8/8.13.8) with ESMTP id n54M5984010295; Thu, 4 Jun 2009 18:05:09 -0400 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx2.corp.redhat.com (8.13.1/8.13.1) with ESMTP id n54M58f7019126; Thu, 4 Jun 2009 18:05:09 -0400 Received: from opsy.redhat.com (vpn-12-161.rdu.redhat.com [10.11.12.161]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id n54M57M3013281; Thu, 4 Jun 2009 18:05:08 -0400 Received: by opsy.redhat.com (Postfix, from userid 500) id E0B15378615; Thu, 4 Jun 2009 16:05:06 -0600 (MDT) To: Samuel Bronson Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 2/2] Add "set/show debug unwinder" prefix commands. References: <1243638987-4533-1-git-send-email-naesten@gmail.com> <1243638987-4533-2-git-send-email-naesten@gmail.com> From: Tom Tromey Reply-To: tromey@redhat.com Date: Thu, 04 Jun 2009 22:05:00 -0000 In-Reply-To: <1243638987-4533-2-git-send-email-naesten@gmail.com> (Samuel Bronson's message of "Fri\, 29 May 2009 19\:16\:27 -0400") Message-ID: User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-06/txt/msg00086.txt.bz2 >>>>> "Samuel" == Samuel Bronson writes: Samuel> Also add one subcommand for tracing the sniffing of stack Samuel> frames by unwinders. This is also basically ok; just needs a ChangeLog and some formatting fixlets, nothing serious. Samuel> +/* trace unwinders called */ Samuel> +static int trace_unwinders; In the GNU style, comments should be sentences, so should start with a capital letter and end with a period followed by two spaces. Yes, we're that nit picky ;) There are a few instances of this. Samuel> + if (trace_unwinders) { Samuel> + fprintf_unfiltered (gdb_stdlog, "[ Searching for unwinder for frame ...\n"); Samuel> + } Drop the braces. Samuel> for (entry = table->list; entry != NULL; entry = entry->next) Samuel> { Samuel> struct cleanup *old_cleanup; Samuel> + const char *uname = entry->unwinder->unwinder_name; Samuel> + Samuel> + if (trace_unwinders) { The opening brace is misplaced here, in the GNU style it goes on the next line. There are a couple instances of this. Samuel> + add_setshow_boolean_cmd ("trace-tried", class_maintenance, &trace_unwinders, I think this could just be "set debug unwinder", rather than "set debug unwinder trace-tried". If you do plan to send another "debug unwinder" sub-command, maybe we could discuss the naming now, before the patch. Tom