From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 17728 invoked by alias); 19 Jun 2009 21:33:58 -0000 Received: (qmail 17720 invoked by uid 22791); 19 Jun 2009 21:33:58 -0000 X-SWARE-Spam-Status: No, hits=-2.3 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mx2.redhat.com (HELO mx2.redhat.com) (66.187.237.31) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 19 Jun 2009 21:33:51 +0000 Received: from int-mx2.corp.redhat.com (int-mx2.corp.redhat.com [172.16.27.26]) by mx2.redhat.com (8.13.8/8.13.8) with ESMTP id n5JLXnwU029311 for ; Fri, 19 Jun 2009 17:33:49 -0400 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx2.corp.redhat.com (8.13.1/8.13.1) with ESMTP id n5JLXmLm014918; Fri, 19 Jun 2009 17:33:48 -0400 Received: from opsy.redhat.com (vpn-12-208.rdu.redhat.com [10.11.12.208]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id n5JLXmuP012910; Fri, 19 Jun 2009 17:33:48 -0400 Received: by opsy.redhat.com (Postfix, from userid 500) id A96D7486CC; Fri, 19 Jun 2009 15:33:47 -0600 (MDT) To: Sami Wagiaalla Cc: GDB Patches Subject: Re: [PATCH 1/2] namespace support References: <4A16BAB5.80602@redhat.com> <4A3BEA01.20106@redhat.com> From: Tom Tromey Reply-To: tromey@redhat.com Date: Fri, 19 Jun 2009 21:33:00 -0000 In-Reply-To: <4A3BEA01.20106@redhat.com> (Sami Wagiaalla's message of "Fri\, 19 Jun 2009 15\:41\:53 -0400") Message-ID: User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-06/txt/msg00518.txt.bz2 >>>>> "Sami" == Sami Wagiaalla writes: Tom> Eww, buildsym is full of globals. Not your problem :-), but yet Tom> another thing that would be nice to clean up. Sami> There is a nice clean up for this suggested by Jan. That is using the Sami> variables in the current context object and automating saving/and Sami> restoration of that. I'll post a patch if I get to it. FWIW I would prefer a fuller cleanup. This approach makes it sound like there would still be one global -- but I don't see why we need any globals at all. At least, we don't need them in the dwarf reader; I don't care as much whether the other readers have module-private globals if that makes the change simpler. Sami> This is a gcc bug. I filed it here: Sami> https://bugzilla.redhat.com/show_bug.cgi?id=506524 and improved Sami> the comment. and improved the comment. For future reference, it is better to file gcc bugs in the gcc bugzilla. They are more likely to be seen there. Also, for some reason in your messages, the patch shows up twice. Does anybody else see that? The version of this patch with the new test case is ok. Thanks. Tom