From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31885 invoked by alias); 21 Sep 2009 16:58:44 -0000 Received: (qmail 31875 invoked by uid 22791); 21 Sep 2009 16:58:44 -0000 X-SWARE-Spam-Status: No, hits=-2.4 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 21 Sep 2009 16:58:40 +0000 Received: from int-mx04.intmail.prod.int.phx2.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.17]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id n8LGwUtn016072; Mon, 21 Sep 2009 12:58:30 -0400 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx04.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id n8LGwTjq028796; Mon, 21 Sep 2009 12:58:29 -0400 Received: from opsy.redhat.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id n8LGwRiR029107; Mon, 21 Sep 2009 12:58:28 -0400 Received: by opsy.redhat.com (Postfix, from userid 500) id 8ABB9378198; Mon, 21 Sep 2009 10:58:27 -0600 (MDT) From: Tom Tromey To: nickrob@snap.net.nz (Nick Roberts) Cc: gdb-patches@sourceware.org Subject: Re: [PATCH:gdb/mi] Update a specified list of variable objects References: <19127.27863.973393.962895@totara.tehura.co.nz> Reply-To: tromey@redhat.com Date: Mon, 21 Sep 2009 16:58:00 -0000 In-Reply-To: <19127.27863.973393.962895@totara.tehura.co.nz> (Nick Roberts's message of "Tue, 22 Sep 2009 00:08:55 +1200") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-09/txt/msg00674.txt.bz2 >>>>> "Nick" == Nick Roberts writes: Nick> -var-update [PRINT_VALUES] NAME1 NAME2 ... Two notes on this patch. First, it needs a documentation change as well. Nick> ! int index = optind; Nick> ! while (argv[index]) { Second, a nit: wrong brace placement. Tom