From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 1619 invoked by alias); 24 Mar 2010 19:02:18 -0000 Received: (qmail 1574 invoked by uid 22791); 24 Mar 2010 19:02:17 -0000 X-SWARE-Spam-Status: No, hits=-7.5 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 24 Mar 2010 19:02:11 +0000 Received: from int-mx08.intmail.prod.int.phx2.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o2OJ29lb009576 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 24 Mar 2010 15:02:09 -0400 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx08.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id o2OJ28kj024492; Wed, 24 Mar 2010 15:02:08 -0400 Received: from opsy.redhat.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id o2OJ27Mv026675; Wed, 24 Mar 2010 15:02:08 -0400 Received: by opsy.redhat.com (Postfix, from userid 500) id 6F65737822D; Wed, 24 Mar 2010 13:02:07 -0600 (MDT) From: Tom Tromey To: Jan Kratochvil Cc: gdb-patches@sourceware.org Subject: Re: [patch] Fix separate-debug with non-unique section names (PR 11409) References: <20100323205655.GA12124@host0.dyn.jankratochvil.net> Reply-To: tromey@redhat.com Date: Wed, 24 Mar 2010 19:02:00 -0000 In-Reply-To: <20100323205655.GA12124@host0.dyn.jankratochvil.net> (Jan Kratochvil's message of "Tue, 23 Mar 2010 21:56:55 +0100") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-03/txt/msg00813.txt.bz2 >>>>> "Jan" == Jan Kratochvil writes: Jan> gdb-7.1 is now broken for example for debugging /usr/bin/emacs due to: Jan> http://sourceware.org/bugzilla/show_bug.cgi?id=11409 Jan> [22] .data PROGBITS 00000000007fe8a0 1fe8a0 215068 00 WA 0 0 32 Jan> [23] .data PROGBITS 0000000000a13920 413920 68c6e0 00 WA 0 0 32 Jan> 2010-03-23 Jan Kratochvil Jan> * symfile.c (addr_info_make_relative): Move sect declaration to the Jan> outer block. Initialize it to NULL. Prefer SECT->next more than Jan> bfd_get_section_by_name. This patch seems to assume that all sections of the same name will be next to each other in the section_addr_info. Why is it ok to make this assumption? Tom