From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 7954 invoked by alias); 20 Apr 2010 18:27:57 -0000 Received: (qmail 7941 invoked by uid 22791); 20 Apr 2010 18:27:56 -0000 X-SWARE-Spam-Status: No, hits=-6.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 20 Apr 2010 18:27:52 +0000 Received: from int-mx05.intmail.prod.int.phx2.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.18]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o3KIRoQs023560 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Tue, 20 Apr 2010 14:27:51 -0400 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx05.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id o3KIRoRE020336; Tue, 20 Apr 2010 14:27:50 -0400 Received: from opsy.redhat.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id o3KIRndv027745; Tue, 20 Apr 2010 14:27:49 -0400 Received: by opsy.redhat.com (Postfix, from userid 500) id 55D4437979C; Tue, 20 Apr 2010 12:27:49 -0600 (MDT) From: Tom Tromey To: Chris Moller Cc: gdb-patches@sourceware.org Subject: Re: PR10687 Printing c++ class with static array (of same type) can produce infinite output References: <4BC524E8.404@redhat.com> Reply-To: tromey@redhat.com Date: Tue, 20 Apr 2010 18:27:00 -0000 In-Reply-To: <4BC524E8.404@redhat.com> (Chris Moller's message of "Tue, 13 Apr 2010 22:14:00 -0400") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-04/txt/msg00623.txt.bz2 >>>>> "Chris" == Chris Moller writes: Chris> Added yet another recursion detector (the third, so far as I noticed) Chris> to cp-valprint.c. This one detects recursing static arrays which, Chris> although it comes unstuck in the same place as the 9067 recursing Chris> static structs, comes unstuck in a different way and thus needs a Chris> slightly different mechanism to detect. Thanks. A couple nits and then this is ok. Chris> addr = value_address (val); Chris> + Chris> obstack_grow (&dont_print_statmem_obstack, (char *) &addr, Chris> sizeof (CORE_ADDR)); Chris> CHECK_TYPEDEF (type); Chris> + Chris> cp_print_value_fields (type, value_enclosing_type (val), Chris> value_contents_all (val), Chris> value_embedded_offset (val), addr, These two newline additions seem gratuitous. Chris> + struct type * target_type = TYPE_TARGET_TYPE (type); No space after the "*" here. This is ok with those changes. Thanks. Tom