From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 28442 invoked by alias); 15 Jun 2010 15:58:27 -0000 Received: (qmail 28430 invoked by uid 22791); 15 Jun 2010 15:58:26 -0000 X-SWARE-Spam-Status: No, hits=-5.8 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,TW_CP,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 15 Jun 2010 15:58:21 +0000 Received: from int-mx05.intmail.prod.int.phx2.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.18]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o5FFwIdW000728 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Tue, 15 Jun 2010 11:58:18 -0400 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx05.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id o5FFwH3l015431; Tue, 15 Jun 2010 11:58:17 -0400 Received: from opsy.redhat.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id o5FFwGHv028822; Tue, 15 Jun 2010 11:58:17 -0400 Received: by opsy.redhat.com (Postfix, from userid 500) id 1989C379863; Tue, 15 Jun 2010 09:58:16 -0600 (MDT) From: Tom Tromey To: "Ulrich Weigand" Cc: gdb-patches@sourceware.org Subject: Re: [commit] Fix "return" command (Re: RFC: optimized-out pieces) References: <201006141213.o5ECDJgj031946@d12av02.megacenter.de.ibm.com> Reply-To: Tom Tromey Date: Tue, 15 Jun 2010 15:58:00 -0000 In-Reply-To: <201006141213.o5ECDJgj031946@d12av02.megacenter.de.ibm.com> (Ulrich Weigand's message of "Mon, 14 Jun 2010 14:13:19 +0200 (CEST)") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-06/txt/msg00340.txt.bz2 >>>>> "Ulrich" == Ulrich Weigand writes: Ulrich> On the other hand, it does not make sense to memcpy an Ulrich> uninitialized value either. Thus, it seems the correct fix Ulrich> is to simply skip the memcpy, and hence the value_contents_all Ulrich> call, if the register value is "optimized out". Thank you for fixing this. I'm sorry for the breakage. Tom