From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 29679 invoked by alias); 30 Mar 2011 10:45:28 -0000 Received: (qmail 29668 invoked by uid 22791); 30 Mar 2011 10:45:27 -0000 X-SWARE-Spam-Status: No, hits=-6.1 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,TW_BJ,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 30 Mar 2011 10:45:19 +0000 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p2UAjI71001207 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Wed, 30 Mar 2011 06:45:18 -0400 Received: from localhost.localdomain (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id p2UAjDiW017775; Wed, 30 Mar 2011 06:45:15 -0400 From: Phil Muldoon To: Kevin Pouget Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [RFC - Python] New ObjFile event References: Reply-to: pmuldoon@redhat.com X-URL: http://www.redhat.com Date: Wed, 30 Mar 2011 12:14:00 -0000 In-Reply-To: (Kevin Pouget's message of "Wed, 30 Mar 2011 05:24:44 -0400") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-03/txt/msg01194.txt.bz2 Kevin Pouget writes: > Hello, > > here is a patch with all the modifications we discussed so far, > including the ChangeLog entry and the new files > Really nice patch! Just one tiny nit... > =C2=A0gdb/ChangeLog=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 |=C2=A0=C2=A0 28 ++++++++++++= +++ This is the ChangeLog for GDB code, so things in gdb/ and python/ code related files have ChangeLog entries here. > @@ -1,3 +1,31 @@ > +2011-03-29 Kevin Pouget > + > +=C2=A0=C2=A0=C2=A0 Allow Python notification of new object-file loadings > +=C2=A0=C2=A0=C2=A0 * Makefile.in (SUBDIR_PYTHON_SRCS): Add py-newobjfile= vent.c. > +=C2=A0=C2=A0=C2=A0 (SUBDIR_PYTHON_OBS): Add py-newobjfileevent.o. > +=C2=A0=C2=A0=C2=A0 Add build rule for this file. > +=C2=A0=C2=A0=C2=A0 * python/py-event.h (emit_new_objfile_event): New pro= totype. > +=C2=A0=C2=A0=C2=A0 (newobjfile): New Python event emitter. > +=C2=A0=C2=A0=C2=A0 * python/py-evts.c (gdbpy_initialize_py_events): Add = newobjfile to > +=C2=A0=C2=A0=C2=A0 Python event registry. > +=C2=A0=C2=A0=C2=A0 * python/py-inferior.c: Include objfiles.h > +=C2=A0=C2=A0=C2=A0 (python_new_objfile): New function. > +=C2=A0=C2=A0=C2=A0 (gdbpy_initialize_inferior): Add python_new_objfile t= o the new objfile > +=C2=A0=C2=A0=C2=A0 observers. > +=C2=A0=C2=A0=C2=A0 * python/py-newobjfileevent.c: New file. > +=C2=A0=C2=A0=C2=A0 * python-internal.h (gdbpy_initialize_new_objfile_eve= nt): New > +=C2=A0=C2=A0=C2=A0 prototype. > +=C2=A0=C2=A0=C2=A0 (gdbpy_current_objfile): New global variable. > +=C2=A0=C2=A0=C2=A0 * python/python.c (gdbpy_current_objfile): Make globa= l. > +=C2=A0=C2=A0=C2=A0 (_initialize_python): Add gdbpy_initialize_new_objfil= e_event call. But the entries below belong in the testsuite/ChangeLog and without the preceding "testsuite" in the log. > +=C2=A0=C2=A0=C2=A0 * testsuite/gdb.python/py-events-shlib.c: New file. > +=C2=A0=C2=A0=C2=A0 * testsuite/gdb.python/py-events.c (do_nothing): New = global. > +=C2=A0=C2=A0=C2=A0 (main): Add call to shared library. > +=C2=A0=C2=A0=C2=A0 * testsuite/gdb.python/py-events.exp: Link the execfi= le to a shared > +=C2=A0=C2=A0=C2=A0 library and check newobjfile event notification. > +=C2=A0=C2=A0=C2=A0 * testsuite/gdb.python/py-events.py (new_objfile_hand= ler): New Class. > +=C2=A0=C2=A0=C2=A0 (test_newobj_events): New class. > + I don't see a documentation entry. Similarly documentation entries are added in the doc/ChangeLog But this patch looks great. Tom or another maintainer will look at it soon. Cheers Phil