Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Tom Tromey <tromey@redhat.com>
To: Andrew Gontarek <andrewg@cray.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] Bug 12705: Extremely poor performance when printing large arrays
Date: Fri, 29 Apr 2011 17:41:00 -0000	[thread overview]
Message-ID: <m339l1dkfw.fsf@fleche.redhat.com> (raw)
In-Reply-To: <4DB70027.2040006@cray.com> (Andrew Gontarek's message of "Tue,	26 Apr 2011 12:25:59 -0500")

>>>>> "Andrew" == Andrew Gontarek <andrewg@cray.com> writes:

Andrew> I noticed that when I wanted to print out a very large array,
Andrew> the performance was unbearably slow. This can be observed by
Andrew> setting print repeats and print elements to 0 (unlimited) and
Andrew> then attempting to print a large array.

This patch looks good.

The patch itself was mangled somehow, maybe your MUA.

I think this is small enough that we can accept it without a copyright
assignment.  If you plan to submit more patches, though, contact me to
get started on the paperwork.

I am running this through our tester, and if it works ok I am going to
check it in.  It looks safe enough for 7.3 as well.

Tom


  reply	other threads:[~2011-04-29 17:41 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-04-26 17:26 Andrew Gontarek
2011-04-29 17:41 ` Tom Tromey [this message]
2011-04-29 19:15   ` Tom Tromey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m339l1dkfw.fsf@fleche.redhat.com \
    --to=tromey@redhat.com \
    --cc=andrewg@cray.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox