From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-82192-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 10520 invoked by alias); 11 Jul 2011 19:50:06 -0000
Received: (qmail 10513 invoked by uid 22791); 11 Jul 2011 19:50:06 -0000
X-SWARE-Spam-Status: No, hits=-6.9 required=5.0	tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD
X-Spam-Check-By: sourceware.org
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 11 Jul 2011 19:49:42 +0000
Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25])	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p6BJnO3Q032567	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK);	Mon, 11 Jul 2011 15:49:24 -0400
Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199])	by int-mx12.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id p6BJnN1M008998;	Mon, 11 Jul 2011 15:49:24 -0400
Received: from barimba (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1])	by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id p6BJnLob010729;	Mon, 11 Jul 2011 15:49:22 -0400
From: Tom Tromey <tromey@redhat.com>
To: Fawzi Mohamed <fawzi.mohamed@nokia.com>
Cc: ext Jan Kratochvil <jan.kratochvil@redhat.com>,        <gdb-patches@sourceware.org>,        ext Tristan Gingold <gingold@adacore.com>,        =?utf-8?B?QW5kcsOpIFDDtm5pdHo=?= <andre.poenitz@nokia.com>
Subject: Re: [PATCH,gdb,Update6]: ensures that cie ptr of an fda is a cie
References: <F1900C4A-1C06-4F4B-9048-16C9A3F03765@nokia.com>	<m3aacsvgnd.fsf@fleche.redhat.com>	<0FC98010-6811-4715-BD3B-AE8B9221C7BF@nokia.com>	<20110706170323.GA28535@host1.jankratochvil.net>	<4A77D598-9262-4A47-813D-0CD977E9DA68@nokia.com>	<m3zkkpq3u9.fsf@fleche.redhat.com>	<870E5F11-1670-4333-B66E-83C297D00182@nokia.com>
Date: Mon, 11 Jul 2011 21:52:00 -0000
In-Reply-To: <870E5F11-1670-4333-B66E-83C297D00182@nokia.com> (Fawzi Mohamed's	message of "Mon, 11 Jul 2011 19:00:04 +0200")
Message-ID: <m339icd2da.fsf@fleche.redhat.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2011-07/txt/msg00287.txt.bz2

>>>>> "Fawzi" == Fawzi Mohamed <fawzi.mohamed@nokia.com> writes:

Fawzi> I added a comment about that.

Better to just use the result.

Fawzi> +		{
Fawzi> +		    /* just shrinks, could be skipped */
Fawzi> +		    xrealloc (fde_table.entries,fde_table.num_entries *
Fawzi> +			      sizeof (fde_table.entries[0]));

Still the wrong indentation here.

Comments must start with an upper-case letter and end with a period and
two spaces.

Tom