From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 1213 invoked by alias); 22 Jul 2011 17:27:27 -0000 Received: (qmail 1205 invoked by uid 22791); 22 Jul 2011 17:27:26 -0000 X-SWARE-Spam-Status: No, hits=-7.5 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 22 Jul 2011 17:27:09 +0000 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p6MHR2dC009014 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Fri, 22 Jul 2011 13:27:02 -0400 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id p6MHR18R004293; Fri, 22 Jul 2011 13:27:01 -0400 Received: from barimba (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id p6MHR0Ht013503; Fri, 22 Jul 2011 13:27:00 -0400 From: Tom Tromey To: Paul Pluzhnikov Cc: Pedro Alves , gdb-patches@sourceware.org, Luis Machado Subject: Re: [RFC][patch] Avoid repeated calls to solib_add on initial attach. References: <20110715205209.8B3B3190BC2@elbrus2.mtv.corp.google.com> <201107201537.18159.pedro@codesourcery.com> Date: Fri, 22 Jul 2011 17:36:00 -0000 In-Reply-To: (Paul Pluzhnikov's message of "Wed, 20 Jul 2011 09:04:11 -0700") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-07/txt/msg00633.txt.bz2 Paul> Going back to the new packet proposal to speed up target_read_string; Paul> do you have any additional comments on Paul> qStr {addr},{maxlen},{terminator} Paul> format? Should {terminator} be optional? Should I avoid it altogether Paul> (it doesn't solve any current problem, so perhaps it's over-design) ? I haven't run across code in gdb that needs to read memory using a delimiter other than \0. So I would suggest leaving it out. Tom