From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31078 invoked by alias); 10 Aug 2011 17:54:54 -0000 Received: (qmail 31068 invoked by uid 22791); 10 Aug 2011 17:54:53 -0000 X-SWARE-Spam-Status: No, hits=-6.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 10 Aug 2011 17:54:38 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p7AHsPx3017452 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Wed, 10 Aug 2011 13:54:25 -0400 Received: from psique (ovpn-112-46.phx2.redhat.com [10.3.112.46]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id p7AHsD7J013622; Wed, 10 Aug 2011 13:54:17 -0400 From: Sergio Durigan Junior To: Abhijit Halder Cc: Eli Zaretskii , tromey@redhat.com, pedro@codesourcery.com, gdb-patches@sourceware.org, jan.kratochvil@redhat.com Subject: Re: [PATCH] An implementation of pipe to make I/O communication between gdb and shell. References: <201108041029.37721.pedro@codesourcery.com> <83pqkjx578.fsf@gnu.org> Date: Wed, 10 Aug 2011 17:54:00 -0000 In-Reply-To: (Abhijit Halder's message of "Tue, 9 Aug 2011 16:12:25 +0530") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-08/txt/msg00225.txt.bz2 Abhijit Halder writes: > I made the corrections suggested during code review. Well, from my perspective I don't think I have anything else about the patch. However, I have some questions: 1) I don't remember if you already answered that, but do you have a copyright assignment (or have you started the process to obtain one)? 2) I believe you can start thinking about a testcase for this feature. I am not sure how you would write this in order to test it on various operating systems, but I think starting with GNU/Linux is OK for now. You may want to take a look at the gdb/testsuite directory for some examples. 3) I also believe that you can write the documentation part for this patch. You will also have to write a NEWS entry. Maybe you can wait a little more until some maintainer reply before start steps 2 and 3. Anyway, it's good to start thinking about these steps. Regards, Sergio.