From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 979 invoked by alias); 26 Aug 2011 20:40:44 -0000 Received: (qmail 971 invoked by uid 22791); 26 Aug 2011 20:40:43 -0000 X-SWARE-Spam-Status: No, hits=-7.2 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD,SPF_HELO_PASS,TW_BJ X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 26 Aug 2011 20:40:25 +0000 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p7QKeOkr024879 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Fri, 26 Aug 2011 16:40:24 -0400 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id p7QKeNUK010774; Fri, 26 Aug 2011 16:40:23 -0400 Received: from barimba (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id p7QKeMRt007872; Fri, 26 Aug 2011 16:40:22 -0400 From: Tom Tromey To: matt rice Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 2/7] [python] API for macros: memory management quirks. References: <1314198654-9008-1-git-send-email-ratmice@gmail.com> <1314198654-9008-3-git-send-email-ratmice@gmail.com> Date: Fri, 26 Aug 2011 20:40:00 -0000 In-Reply-To: <1314198654-9008-3-git-send-email-ratmice@gmail.com> (matt rice's message of "Wed, 24 Aug 2011 08:10:49 -0700") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-08/txt/msg00511.txt.bz2 >>>>> "matt" == matt rice writes: matt> 2011-08-23 Matt Rice * dwarf2read.c (macro_start_file): Update args in call to matt> new_macro_table. matt> * macroscope.c (_initialize_macroscope): Ditto. matt> * macrotab.c (struct macro_table): Remove obstack and bcache, matt> add objfile. matt> (macro_alloc): Replace obstack and bcache usage with those from matt> the objfile. matt> (macro_free, macro_bcache_free, macro_allow_redefinitions): Ditto matt> (macro_bcache, new_macro_table): Ditto, and add assertions. matt> (macro_table_objfile): New function. matt> * macrotab.h: Replace forward declarations of bcache and obstack matt> with objfile. matt> (enum macro_table_type, macro_table_objfile): Add. A couple minor nits on this one. matt> +new_macro_table (struct objfile *objfile, enum macro_table_type table_type) I don't think we need the new enum or the second argument here. Checking whether OBJFILE==NULL is good enough. matt> +struct objfile * macro_table_objfile (struct macro_table *table); No space after the *. Ok with these changes, contingent on the whole series being ok'd. Tom