From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 11388 invoked by alias); 24 Oct 2011 12:34:32 -0000 Received: (qmail 11187 invoked by uid 22791); 24 Oct 2011 12:34:31 -0000 X-SWARE-Spam-Status: No, hits=-6.8 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 24 Oct 2011 12:34:10 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p9OCY9lO004336 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Mon, 24 Oct 2011 08:34:09 -0400 Received: from localhost.localdomain (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id p9OCY85l019695 for ; Mon, 24 Oct 2011 08:34:09 -0400 From: Phil Muldoon To: gdb-patches@sourceware.org Subject: [python] [patch] PR python/13316 Reply-to: pmuldoon@redhat.com X-URL: http://www.redhat.com Date: Mon, 24 Oct 2011 12:54:00 -0000 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-10/txt/msg00623.txt.bz2 This patch (found by David Malcolm's GCC plug-in Python reference check), fixes a case where we do not decrement a value in two branches of py-param.c:compute_enum_values. OK? Cheers, Phil -- 2011-10-24 Phil Muldoon PR python/13316 * python/py-param.c (compute_enum_values): Decrement decrement PyObjects on function exit. -- Index: python/py-param.c =================================================================== RCS file: /cvs/src/src/gdb/python/py-param.c,v retrieving revision 1.14 diff -u -r1.14 py-param.c --- python/py-param.c 24 Oct 2011 11:39:50 -0000 1.14 +++ python/py-param.c 24 Oct 2011 12:28:52 -0000 @@ -605,9 +605,12 @@ do_cleanups (back_to); PyErr_SetString (PyExc_RuntimeError, _("The enumeration item not a string.")); + Py_DECREF (item); return 0; } self->enumeration[i] = python_string_to_host_string (item); + Py_DECREF (item); + if (self->enumeration[i] == NULL) { do_cleanups (back_to);