From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 12531 invoked by alias); 12 Jun 2013 22:01:58 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 12513 invoked by uid 89); 12 Jun 2013 22:01:55 -0000 X-Spam-SWARE-Status: No, score=-6.3 required=5.0 tests=AWL,BAYES_00,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.1 Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Wed, 12 Jun 2013 22:01:54 +0000 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r5CM1rRs025131 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 12 Jun 2013 18:01:53 -0400 Received: from psique (ovpn-113-169.phx2.redhat.com [10.3.113.169]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id r5CM1o4L018893 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Wed, 12 Jun 2013 18:01:52 -0400 From: Sergio Durigan Junior To: Phil Muldoon Cc: "gdb-patches\@sourceware.org" Subject: Re: [rfc] Add help text to start-up text References: <51B8D10E.5030409@redhat.com> X-URL: http://www.redhat.com Date: Thu, 13 Jun 2013 01:29:00 -0000 In-Reply-To: <51B8D10E.5030409@redhat.com> (Phil Muldoon's message of "Wed, 12 Jun 2013 20:50:38 +0100") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2013-06/txt/msg00294.txt.bz2 On Wednesday, June 12 2013, Phil Muldoon wrote: > This patch proposes to add a few items to the GDB start-up text to > provide some indication on where the user can find help. Thanks for the patch, Phil! > Also I am not sure if anything actually parses the initial output of > the GDB start-up text and if adding these lines will affect that. So > I am seeking comments. That's a good question, but honestly I believe it would be counter-productive to do such checks. I tried to check Eclipse but couldn't find myself inside the source-code. Anyway, we'd better wait for someone with more knowledge in this. > 2013-06-12 Phil Muldoon > > * top.c (print_gdb_version): Add help, apropos description and > urls to wiki and online documentation. You probably could mention your own PR 12735 in the ChangeLog entry :-). > diff --git a/gdb/top.c b/gdb/top.c > index 8ac756f..4c85b51 100644 > --- a/gdb/top.c > +++ b/gdb/top.c > @@ -1156,8 +1156,16 @@ Type \"show configuration\" for configuration details."); > { > fprintf_filtered (stream, > _("\nFor bug reporting instructions, please see:\n")); > - fprintf_filtered (stream, "%s.", REPORT_BUGS_TO); > + fprintf_filtered (stream, "%s.\n\n", REPORT_BUGS_TO); > } > + > + fprintf_filtered (stream, _("The GDB manual can be found online at:\n\ > +\n")); > + fprintf_filtered (stream, _("The GDB wiki can be found online at:\n\ > +\n\n")); I think the link for the wiki can go in the same line, without the break. > + fprintf_filtered (stream, _("For help, type 'help'.\n")); > + fprintf_filtered (stream, _("Type 'apropos word' to search for \ > +commands related to 'word'.\n")); These two lines could be joined, WDYT? For help, type 'help'. Type 'apropos word' to search for commands related to 'word'. I already think GDB's initialization text is too verbose nowadays, and it will become even more verbose with this patch. It's not that I don't think your patch is useful (much to the contrary), but maybe we could try to summarize the info a little bit? Currently GDB displays (in my Fedora 17 x86_64): $ gdb GNU gdb (GDB) Fedora (7.4.50.20120120-54.fc17) Copyright (C) 2012 Free Software Foundation, Inc. License GPLv3+: GNU GPL version 3 or later This is free software: you are free to change and redistribute it. There is NO WARRANTY, to the extent permitted by law. Type "show copying" and "show warranty" for details. This GDB was configured as "x86_64-redhat-linux-gnu". For bug reporting instructions, please see: . It could be (this is just a proposal, of course): $ gdb GNU gdb (GDB) Fedora (7.4.50.20120120-54.fc17) License: GPLv3+. This is free software: you are free to change and redistribute it. Type "show copying" and "show warranty" for details. This GDB was configured as "x86_64-redhat-linux-gnu". And then, with your patch (and my proposed modifications): $ gdb GNU gdb (GDB) Fedora (7.4.50.20120120-54.fc17) License: GPLv3+. This is free software: you are free to change and redistribute it. Type "show copying" and "show warranty" for details. This GDB was configured as "x86_64-redhat-linux-gnu". The GDB manual can be found online at: The GDB wiki can be found online at: For help, type 'help'. Type 'apropos word' to search for commands related to 'word'. Anyway, I know this is a topic which can become a hot discussion, but since you opened the Pandora box... :-) Thanks, -- Sergio