From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 65392 invoked by alias); 30 May 2017 16:42:01 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 65366 invoked by uid 89); 30 May 2017 16:42:01 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.1 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RCVD_IN_DNSWL_LOW autolearn=no version=3.3.2 spammy=Various, transfer X-HELO: mx0a-001b2d01.pphosted.com Received: from mx0a-001b2d01.pphosted.com (HELO mx0a-001b2d01.pphosted.com) (148.163.156.1) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 30 May 2017 16:41:59 +0000 Received: from pps.filterd (m0098396.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.20/8.16.0.20) with SMTP id v4UGckgb049623 for ; Tue, 30 May 2017 12:42:02 -0400 Received: from e06smtp12.uk.ibm.com (e06smtp12.uk.ibm.com [195.75.94.108]) by mx0a-001b2d01.pphosted.com with ESMTP id 2as5shbsyc-1 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT) for ; Tue, 30 May 2017 12:42:01 -0400 Received: from localhost by e06smtp12.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Tue, 30 May 2017 17:41:59 +0100 Received: from b06cxnps3074.portsmouth.uk.ibm.com (9.149.109.194) by e06smtp12.uk.ibm.com (192.168.101.142) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Tue, 30 May 2017 17:41:58 +0100 Received: from d06av26.portsmouth.uk.ibm.com (d06av26.portsmouth.uk.ibm.com [9.149.105.62]) by b06cxnps3074.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id v4UGfviX12583332 for ; Tue, 30 May 2017 16:41:57 GMT Received: from d06av26.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 532E0AE051 for ; Tue, 30 May 2017 17:39:40 +0100 (BST) Received: from d06av26.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 38938AE053 for ; Tue, 30 May 2017 17:39:40 +0100 (BST) Received: from oc1027705133.ibm.com (unknown [9.152.212.109]) by d06av26.portsmouth.uk.ibm.com (Postfix) with ESMTPS for ; Tue, 30 May 2017 17:39:40 +0100 (BST) From: Andreas Arnez To: gdb-patches@sourceware.org Subject: [ping] [PATCH v2 00/19] Various DWARF piece fixes Date: Tue, 30 May 2017 16:42:00 -0000 In-Reply-To: <1494352015-10465-1-git-send-email-arnez@linux.vnet.ibm.com> (Andreas Arnez's message of "Tue, 9 May 2017 19:45:56 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-TM-AS-GCONF: 00 x-cbid: 17053016-0008-0000-0000-00000458CC60 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 17053016-0009-0000-0000-00001DDBB31D Message-Id: X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-05-30_10:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=1 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1703280000 definitions=main-1705300308 X-IsSubscribed: yes X-SW-Source: 2017-05/txt/msg00624.txt.bz2 Ping: https://sourceware.org/ml/gdb-patches/2017-05/msg00215.html ON Tue, May 09 2017, Andreas Arnez wrote: > This series fixes various issues with DWARF piece handling. > Specifically it almost rewrites the functions read_pieced_value and > write_pieced_value in multiple steps. Test cases are added as well. So far I've received feedback from Yao, and for v1 also from Simon. Thanks again for that! Now, if I tracked correctly, the patches check-marked with [X] are approved: - [X] Add test for modifiable DWARF locations - [X] write_pieced_value: Fix size capping logic - [X] PR gdb/21226: Take DWARF stack value pieces from LSB end - [X] Remove addr_size field from struct piece_closure - [X] gdb/testsuite: Add "get_endianness" convenience proc - [X] read/write_pieced_value: Respect value parent's offset - [X] write_pieced_value: Fix copy/paste error in size calculation - [X] write_pieced_value: Include transfer size in byte-wise check - [X] write_pieced_value: Fix buffer offset for memory pieces - [X] write_pieced_value: Transfer least significant bits into bit-field - [X] Add DWARF piece test cases for bit-field access - [X] read/write_pieced_value: Drop 'buffer_size' variable - [ ] Fix handling of DWARF register pieces on big-endian targets - [ ] read/write_pieced_value: Improve logic for buffer allocation - [X] Respect piece offset for DW_OP_bit_piece - [ ] read/write_pieced_value: Remove unnecessary variable copies - [ ] Fix bit-/byte-offset mismatch in parameter to read_value_memory - [X] write_pieced_value: Notify memory_changed observers - [ ] read/write_pieced_value: Merge into one function For the 5 non-check-marked patches I haven't received feedback yet. -- Andreas