From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 129567 invoked by alias); 10 Oct 2019 10:29:45 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 129558 invoked by uid 89); 10 Oct 2019 10:29:45 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-10.2 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.1 spammy=Arnez X-HELO: mx0a-001b2d01.pphosted.com Received: from mx0b-001b2d01.pphosted.com (HELO mx0a-001b2d01.pphosted.com) (148.163.158.5) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 10 Oct 2019 10:29:43 +0000 Received: from pps.filterd (m0098416.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.16.0.27/8.16.0.27) with SMTP id x9A9Rgmd156257 for ; Thu, 10 Oct 2019 06:29:41 -0400 Received: from e06smtp05.uk.ibm.com (e06smtp05.uk.ibm.com [195.75.94.101]) by mx0b-001b2d01.pphosted.com with ESMTP id 2vhyqx6gty-1 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NOT) for ; Thu, 10 Oct 2019 06:29:41 -0400 Received: from localhost by e06smtp05.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 10 Oct 2019 11:29:39 +0100 Received: from b06avi18626390.portsmouth.uk.ibm.com (9.149.26.192) by e06smtp05.uk.ibm.com (192.168.101.135) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; (version=TLSv1/SSLv3 cipher=AES256-GCM-SHA384 bits=256/256) Thu, 10 Oct 2019 11:29:37 +0100 Received: from d06av22.portsmouth.uk.ibm.com (d06av22.portsmouth.uk.ibm.com [9.149.105.58]) by b06avi18626390.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id x9AAT6op38535436 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 10 Oct 2019 10:29:06 GMT Received: from d06av22.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id C90A14C05C; Thu, 10 Oct 2019 10:29:36 +0000 (GMT) Received: from d06av22.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 9A1B14C050; Thu, 10 Oct 2019 10:29:36 +0000 (GMT) Received: from oc0404454431.ibm.com (unknown [9.152.222.48]) by d06av22.portsmouth.uk.ibm.com (Postfix) with ESMTPS; Thu, 10 Oct 2019 10:29:36 +0000 (GMT) From: Andreas Arnez To: Tom Tromey Cc: gdb-patches@sourceware.org, Alan Hayward , Andrew Burgess Subject: Re: [PATCH] gdb/testsuite: Fix typos in infcall-nested-structs.c In-Reply-To: <87lfttdcmv.fsf@tromey.com> (Tom Tromey's message of "Wed, 09 Oct 2019 11:58:32 -0600") References: <87lfttdcmv.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux) Date: Thu, 10 Oct 2019 10:29:00 -0000 MIME-Version: 1.0 Content-Type: text/plain x-cbid: 19101010-0020-0000-0000-00000377D045 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 19101010-0021-0000-0000-000021CDDBE8 Message-Id: X-SW-Source: 2019-10/txt/msg00274.txt.bz2 On Wed, Oct 09 2019, Tom Tromey wrote: >>>>>> "Andreas" == Andreas Arnez writes: [...] > Andreas> gdb/testsuite/ChangeLog: > > Andreas> * gdb.base/infcall-nested-structs.c (cmp_struct_02_01) > Andreas> (cmp_struct_02_02, cmp_struct_04_01, cmp_struct_04_02) > Andreas> (cmp_struct_05_01, cmp_struct_static_02_01) > Andreas> (cmp_struct_static_04_01, cmp_struct_static_06_01): Fix redundant > Andreas> comparisons. > > Thank you. This looks reasonable to me. I think you could have put it > in under the obvious rule, even. Yeah, this does seem obvious... Thanks anyway! Pushed as 6dfc00411292aa3220b33b6ac9553907e3933b0f. -- Andreas