From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 27831 invoked by alias); 24 Aug 2008 16:41:04 -0000 Received: (qmail 27823 invoked by uid 22791); 24 Aug 2008 16:41:03 -0000 X-Spam-Check-By: sourceware.org Received: from mx2.redhat.com (HELO mx2.redhat.com) (66.187.237.31) by sourceware.org (qpsmtpd/0.31) with ESMTP; Sun, 24 Aug 2008 16:40:28 +0000 Received: from int-mx2.corp.redhat.com (int-mx2.corp.redhat.com [172.16.27.26]) by mx2.redhat.com (8.13.8/8.13.8) with ESMTP id m7OGdOgY030306; Sun, 24 Aug 2008 12:39:44 -0400 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx2.corp.redhat.com (8.13.1/8.13.1) with ESMTP id m7OGdDw5025173; Sun, 24 Aug 2008 12:39:13 -0400 Received: from opsy.redhat.com (vpn-10-23.bos.redhat.com [10.16.10.23]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id m7OGd34h029365; Sun, 24 Aug 2008 12:39:03 -0400 Received: by opsy.redhat.com (Postfix, from userid 500) id 4FA6637831C; Sun, 24 Aug 2008 10:39:12 -0600 (MDT) To: Joel Brobecker Cc: gdb-patches@sourceware.org Subject: Re: RFA: shrink main_type References: <20080818130009.GM16894@adacore.com> <20080818132001.GA9434@caradoc.them.org> <20080819051306.GQ16894@adacore.com> <20080824101221.GA3738@adacore.com> From: Tom Tromey Reply-To: Tom Tromey X-Attribution: Tom Date: Sun, 24 Aug 2008 16:41:00 -0000 In-Reply-To: <20080824101221.GA3738@adacore.com> (Joel Brobecker's message of "Sun\, 24 Aug 2008 12\:12\:21 +0200") Message-ID: User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-08/txt/msg00597.txt.bz2 >>>>> "Joel" == Joel Brobecker writes: Joel> Looks good! Please commit. Thanks. dwarf2read.c needed the additional appended hunk in order to compile. This file changed since I wrote this patch. So, I am including this in what I am going to commit. Tom *************** *** 5000,5006 **** TYPE_TARGET_TYPE (type) = target_type; if (name && strcmp (name, "char") == 0) ! TYPE_FLAGS (type) |= TYPE_FLAG_NOSIGN; return set_die_type (die, type, cu); } --- 5001,5007 ---- TYPE_TARGET_TYPE (type) = target_type; if (name && strcmp (name, "char") == 0) ! TYPE_NOSIGN (type) = 1; return set_die_type (die, type, cu); }