From: Tom Tromey <tromey@redhat.com>
To: Joel Brobecker <brobecker@adacore.com>
Cc: gdb-patches@sourceware.org
Subject: Re: RFA: fix crash in expression evaluation
Date: Thu, 30 Oct 2008 21:50:00 -0000 [thread overview]
Message-ID: <m31vxxkfsr.fsf@fleche.redhat.com> (raw)
In-Reply-To: <20081030035443.GB13387@adacore.com> (Joel Brobecker's message of "Wed\, 29 Oct 2008 20\:54\:43 -0700")
>>>>> "Joel" == Joel Brobecker <brobecker@adacore.com> writes:
Tom> + struct type *type;
Joel> Nit-picking. I think that the general convention here is to separate
Joel> local declarations from the rest of the block with an empty line.
Ok, fixed.
Joel> I don't think the second line is useful, is it? type should
Joel> necessarily be a TYPE_CODE_PTR, if I understand
Joel> value_coerce_array correctly. So it goes from being a
Joel> TYPE_CODE_ARRAY to a TYPE_CODE_PTR. In neither case will it
Joel> cause the check just below to be true.
Yeah, good point.
Joel> Honestly, I think that the code is poorly written. How about using
Joel> a case statement or at least a if/else if sequence. Would something
Joel> like this work?
Looks good to me.
I'll send it through the tester.
Tom
next prev parent reply other threads:[~2008-10-30 21:48 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-02 17:27 Tom Tromey
2008-10-30 4:04 ` Joel Brobecker
2008-10-30 21:50 ` Tom Tromey [this message]
2008-10-30 21:48 ` Tom Tromey
2008-10-30 21:42 ` Joel Brobecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m31vxxkfsr.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox