From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-60255-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 13114 invoked by alias); 24 Nov 2008 16:33:43 -0000
Received: (qmail 13071 invoked by uid 22791); 24 Nov 2008 16:33:42 -0000
X-Spam-Check-By: sourceware.org
Received: from mx2.redhat.com (HELO mx2.redhat.com) (66.187.237.31)     by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 24 Nov 2008 16:33:07 +0000
Received: from int-mx2.corp.redhat.com (int-mx2.corp.redhat.com [172.16.27.26]) 	by mx2.redhat.com (8.13.8/8.13.8) with ESMTP id mAOGWvul027994 	for <gdb-patches@sourceware.org>; Mon, 24 Nov 2008 11:32:57 -0500
Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) 	by int-mx2.corp.redhat.com (8.13.1/8.13.1) with ESMTP id mAOGWuTH001535; 	Mon, 24 Nov 2008 11:32:56 -0500
Received: from opsy.redhat.com (vpn-12-223.rdu.redhat.com [10.11.12.223]) 	by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id mAOGWuIc031498; 	Mon, 24 Nov 2008 11:32:56 -0500
Received: by opsy.redhat.com (Postfix, from userid 500) 	id 610AE378788; Mon, 24 Nov 2008 09:32:55 -0700 (MST)
To: Jan Kratochvil <jan.kratochvil@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [patch] Fix completer access of an already freed memory
References: <20081122231304.GA12471@host0.dyn.jankratochvil.net>
From: Tom Tromey <tromey@redhat.com>
Reply-To: tromey@redhat.com
X-Attribution:  Tom
Date: Mon, 24 Nov 2008 19:48:00 -0000
In-Reply-To: <20081122231304.GA12471@host0.dyn.jankratochvil.net> (Jan Kratochvil's message of "Sun\, 23 Nov 2008 00\:13\:04 +0100")
Message-ID: <m31vx13wzt.fsf@fleche.redhat.com>
User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.2 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2008-11/txt/msg00646.txt.bz2

>>>>> "Jan" == Jan Kratochvil <jan.kratochvil@redhat.com> writes:

Jan> 2008-11-22  Jan Kratochvil  <jan.kratochvil@redhat.com>
Jan> 	Fix access of an already freed memory.
Jan> 	* parse.c (parse_field_expression): Call xstrdup on `*name'.
Jan> 	* completer.c (expression_completer): Free fieldname.

Thanks.  FWIW, this looks reasonable to me.  I can't approve it though.

Tom