From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5063 invoked by alias); 22 Jun 2009 17:54:58 -0000 Received: (qmail 4966 invoked by uid 22791); 22 Jun 2009 17:54:57 -0000 X-SWARE-Spam-Status: No, hits=-2.3 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mx2.redhat.com (HELO mx2.redhat.com) (66.187.237.31) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 22 Jun 2009 17:54:51 +0000 Received: from int-mx2.corp.redhat.com (int-mx2.corp.redhat.com [172.16.27.26]) by mx2.redhat.com (8.13.8/8.13.8) with ESMTP id n5MHqiIk004536; Mon, 22 Jun 2009 13:52:44 -0400 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx2.corp.redhat.com (8.13.1/8.13.1) with ESMTP id n5MHqh2r029298; Mon, 22 Jun 2009 13:52:43 -0400 Received: from opsy.redhat.com (vpn-13-249.rdu.redhat.com [10.11.13.249]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id n5MHqfoR024296; Mon, 22 Jun 2009 13:52:42 -0400 Received: by opsy.redhat.com (Postfix, from userid 500) id A306B888077; Mon, 22 Jun 2009 11:52:40 -0600 (MDT) To: Doug Evans Cc: Pedro Alves , Eli Zaretskii , gdb-patches Subject: Re: [RFA] Fix too many "no debugging symbols found" warnings. References: <20090523232414.BED2B846C2@localhost> <200906042221.22713.pedro@codesourcery.com> <200906051949.45647.pedro@codesourcery.com> From: Tom Tromey Reply-To: Tom Tromey Date: Mon, 22 Jun 2009 17:54:00 -0000 In-Reply-To: (Doug Evans's message of "Thu\, 18 Jun 2009 17\:47\:46 -0700") Message-ID: User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-06/txt/msg00569.txt.bz2 >>>>> "Doug" == Doug Evans writes: Doug> What's the reason for passing from_tty=0 to symbol_file_add_main from Doug> captured_main? For questions like this I think the only thing to do is some archaeology. I looked, though, and this seems to have been 0 all the way back to 1.1 in the src repository. (I don't think I have ready access to the older Cygnus repository any more.) Doug> What do folks think about having gdb print an extra line when starting up? Doug> i.e. adding: Doug> Reading symbols from /home/dje/src/hello.x64...done. Doug> Or, when no debugging symbols are found: Doug> Reading symbols from /home/dje/src/hello.x64...(no debugging symbols Doug> found) ...done. Doug> [gdb would previously print "(not debugging symbols found)"] I think it is a good idea. It tells the user clearly what gdb is doing, and it gets rid of the confusing output they see now. Let's do it. Doug> This partially reverts my patch of 2008-07-10 that added the option Doug> "set print symbol-loading". Doug> In its place I changed symbol-loading to symbol-loading-warnings and Doug> made it only apply when from_tty == 0. Doug> And I set the default to "off". Doug> If from_tty == 1, the request is from the user directly (more or Doug> less), and the user more likely wants to know if no debugging symbols Doug> are found. Doug> Plus if from_tty == 1, the user is already getting the text "Reading Doug> ..." so why test the "set print ..." option? Sounds reasonable. Doug> This patch also includes the name of the file without debugging Doug> symbols in the "no debugging symbols found" message. Nice. Doug> Thoughts (especially about my first two questions) ? I like this patch. I think it is ok. However, since output changes are typically contentious, please wait a while to give others a chance to respond. Tom