From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 3094 invoked by alias); 29 Jul 2009 19:24:24 -0000 Received: (qmail 3082 invoked by uid 22791); 29 Jul 2009 19:24:23 -0000 X-SWARE-Spam-Status: No, hits=-2.3 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mx2.redhat.com (HELO mx2.redhat.com) (66.187.237.31) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 29 Jul 2009 19:24:18 +0000 Received: from int-mx2.corp.redhat.com (int-mx2.corp.redhat.com [172.16.27.26]) by mx2.redhat.com (8.13.8/8.13.8) with ESMTP id n6TJMGMk031729; Wed, 29 Jul 2009 15:22:16 -0400 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx2.corp.redhat.com (8.13.1/8.13.1) with ESMTP id n6TJMB9k028796; Wed, 29 Jul 2009 15:22:12 -0400 Received: from opsy.redhat.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id n6TJMBQa002768; Wed, 29 Jul 2009 15:22:11 -0400 Received: by opsy.redhat.com (Postfix, from userid 500) id B650F3784EC; Wed, 29 Jul 2009 13:22:10 -0600 (MDT) To: Jan Kratochvil Cc: Vladimir Prus , gdb-patches@sourceware.org Subject: Re: [patch 0/4] varobj_list replacement [Re: [patch 4/8] Types GC [varobj_list to all_root_varobjs]] References: <20090525080233.GD13323@host0.dyn.jankratochvil.net> <20090702083705.GA14783@host0.dyn.jankratochvil.net> <200907021409.39886.vladimir@codesourcery.com> <20090710201104.GA7014@host0.dyn.jankratochvil.net> From: Tom Tromey Reply-To: Tom Tromey Date: Wed, 29 Jul 2009 21:34:00 -0000 In-Reply-To: <20090710201104.GA7014@host0.dyn.jankratochvil.net> (Jan Kratochvil's message of "Fri\, 10 Jul 2009 22\:11\:04 +0200") Message-ID: User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-07/txt/msg00718.txt.bz2 >>>>> "Jan" == Jan Kratochvil writes: Volodya> Can we just make varobj.c expose vector of varobjs? Jan> In general iterators are preferred over direct variable access in Jan> modern programming. Yeah, but what about in gdb? ;) Jan> Still I would prefer: Jan> Iterator - so-called "safe" (keeping the next pointer) double link list: This patch (assuming it was the 4/4 patch) seemed pretty clean to me. I did not read all the patches. I'm happy to do so and review them, but I didn't want to overstep into Volodya's maintainership area. Jan> Regression tested all the 4 patches on {x86_64,i686}-fedora-linux-gnu. So, I have a few comments on this. I understand from other mail that this patch is a prerequisite to the type GC work. However, I don't understand in what way it is needed. I probably missed something... could you either explain it or tell me where to look? Second, I did not see a response to any of these patches. So, ping. Third, I think it is strange to send four patches that do the same thing in different ways. I am certain that we can all communicate better than this, and come to an agreement about direction beforehand. Tom