From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-66739-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 31034 invoked by alias); 11 Sep 2009 20:51:17 -0000
Received: (qmail 31025 invoked by uid 22791); 11 Sep 2009 20:51:17 -0000
X-SWARE-Spam-Status: No, hits=-2.1 required=5.0 	tests=AWL,BAYES_00,J_CHICKENPOX_57,SPF_HELO_PASS,SPF_PASS
X-Spam-Check-By: sourceware.org
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28)     by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 11 Sep 2009 20:51:11 +0000
Received: from int-mx08.intmail.prod.int.phx2.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.21]) 	by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id n8BKog1a010667; 	Fri, 11 Sep 2009 16:50:42 -0400
Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) 	by int-mx08.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id n8BKoeAM012129; 	Fri, 11 Sep 2009 16:50:41 -0400
Received: from opsy.redhat.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) 	by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id n8BKocNa002073; 	Fri, 11 Sep 2009 16:50:39 -0400
Received: by opsy.redhat.com (Postfix, from userid 500) 	id 85BDD378188; Fri, 11 Sep 2009 14:50:38 -0600 (MDT)
From: Tom Tromey <tromey@redhat.com>
To: Paul Pluzhnikov <ppluzhnikov@google.com>
Cc: Pierre Muller <muller@ics.u-strasbg.fr>,         Joel Brobecker <brobecker@adacore.com>,         Ulrich Weigand <Ulrich.Weigand@de.ibm.com>,         gdb-patches ml <gdb-patches@sourceware.org>,         Jan Kratochvil <jan.kratochvil@redhat.com>
Subject: Re: [patch] Speed up find_pc_section
References: <8ac60eac0908201340k6b759eb5o9bb73c8f473d8785@mail.gmail.com> 	<200908211130.n7LBUCJc011108@d12av02.megacenter.de.ibm.com> 	<8ac60eac0908231548x135edf2doa04fa59a49455bcd@mail.gmail.com> 	<8ac60eac0908260020l4200cf84v2686a76b5858d13@mail.gmail.com> 	<20090909055824.GB11738@adacore.com> 	<8ac60eac0909101036r101263e7qd11c1a69f13008f1@mail.gmail.com> 	<20090910182952.GK20694@adacore.com> 	<8ac60eac0909101829g5384d665gdab27526fe95c27c@mail.gmail.com> 	<000c01ca32ac$0ca9f8b0$25fdea10$@u-strasbg.fr> 	<8ac60eac0909110029q1c88dcetdb644fa461fa545c@mail.gmail.com>
Reply-To: Tom Tromey <tromey@redhat.com>
Date: Fri, 11 Sep 2009 20:51:00 -0000
In-Reply-To: <8ac60eac0909110029q1c88dcetdb644fa461fa545c@mail.gmail.com> 	(Paul Pluzhnikov's message of "Fri, 11 Sep 2009 00:29:19 -0700")
Message-ID: <m31vmdgq8x.fsf@fleche.redhat.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2009-09/txt/msg00334.txt.bz2

>>>>> "Paul" == Paul Pluzhnikov <ppluzhnikov@google.com> writes:

I'm finally catching up on this thread...

Paul> Perhaps I should just add a sequence number to 'struct objfile'? That
Paul> looks like it would almost give exact same ordering as what GDB used
Paul> before qsort+bsearch was introduced.

Is there some benefit to the old ordering?

I assumed that the old approach just gave the user an arbitrary
ordering, in which case any change here is no big deal.  But, if there
is a benefit to the old ordering, sure, restore it.

How stable a sort would you want?  You could just fall back to the
objfile's address.  Or is that too awful?

Tom