Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Tom Tromey <tromey@redhat.com>
To: Anthony Green <green@moxielogic.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [Patch, moxie, sim] Use common memory infrastructure & introduce 	device tree source
Date: Fri, 11 Sep 2009 21:44:00 -0000	[thread overview]
Message-ID: <m31vmdf975.fsf@fleche.redhat.com> (raw)
In-Reply-To: <1252619996.7349.24.camel@localhost.localdomain> (Anthony Green's 	message of "Thu, 10 Sep 2009 17:59:56 -0400")

>>>>> "Anthony" == Anthony Green <green@moxielogic.com> writes:

Anthony> Index: sim/moxie/Makefile.in
Anthony> ===================================================================

This doesn't use the new subst "DTC".

Anthony> +all: interp.o moxie-gdb.dtb
Anthony> +moxie-gdb.dtb: moxie-gdb.dts
Anthony> +	dtc -O dtb -o moxie-gdb.dtb ${srcdir}/moxie-gdb.dts

Also, it unconditionally runs dtc.

Is it intended to work if dtc is not found?
If so then this stuff should be conditional somehow.

Anthony> +AC_CHECK_TOOL(DTC, dtc)

Otherwise, if dtc is always necessary, then there's no need for this
check.

Tom


      reply	other threads:[~2009-09-11 21:44 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-09-10 21:56 Anthony Green
2009-09-11 21:44 ` Tom Tromey [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m31vmdf975.fsf@fleche.redhat.com \
    --to=tromey@redhat.com \
    --cc=gdb-patches@sourceware.org \
    --cc=green@moxielogic.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox