Re: GDB 6.8.92 available for testing

Joel Brobecker
2009-10-01T19:40:47Z

[-- Attachment #1: Type: text/plain, Size: 672 bytes --]

[switching to gcc-patches]

> Given that newer GCC versions get whinier and whinier and that we see
> false positives from time to time, I would be in favour of disabling
> -Werror for releases.

Makes sense to me. I've just committed the following patch on the branch,
after having re-built GDB on x86-linux, making sure that -Werror is no
longer used by default anymore. (this is the same patch than the one
I applied for GDB 6.6 by the way).

2009-10-01 Joel Brobecker <brobecker@adacore.com>

* configure.ac: Disable -Werror by default.
* configure: Regenerate.

I'll update my release procedure/scripts to do the same for future
releases.

--
Joel

[-- Attachment #2: werror.diff --]
[-- Type: text/x-diff, Size: 1200 bytes --]

Index: configure.ac
===================================================================
RCS file: /cvs/src/src/gdb/configure.ac,v
retrieving revision 1.106
diff -u -p -r1.106 configure.ac
--- configure.ac 10 Sep 2009 03:59:36 -0000 1.106
+++ configure.ac 1 Oct 2009 19:17:55 -0000
@@ -1510,11 +1510,6 @@ AC_ARG_ENABLE(werror,
*) AC_MSG_ERROR(bad value ${enableval} for --enable-werror) ;;
esac])

-# Enable -Werror by default when using gcc
-if test "${GCC}" = yes -a -z "${ERROR_ON_WARNING}" ; then
- ERROR_ON_WARNING=yes
-fi
-
WERROR_CFLAGS=""
if test "${ERROR_ON_WARNING}" = yes ; then
WERROR_CFLAGS="-Werror"
Index: configure
===================================================================
RCS file: /cvs/src/src/gdb/configure,v
retrieving revision 1.288
diff -u -p -r1.288 configure
--- configure 10 Sep 2009 03:59:37 -0000 1.288
+++ configure 1 Oct 2009 19:17:59 -0000
@@ -13067,11 +13067,6 @@ if test "${enable_werror+set}" = set; th
fi

-# Enable -Werror by default when using gcc
-if test "${GCC}" = yes -a -z "${ERROR_ON_WARNING}" ; then
- ERROR_ON_WARNING=yes
-fi
-
WERROR_CFLAGS=""
if test "${ERROR_ON_WARNING}" = yes ; then
WERROR_CFLAGS="-Werror"