From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 27293 invoked by alias); 9 Nov 2009 17:42:14 -0000 Received: (qmail 27285 invoked by uid 22791); 9 Nov 2009 17:42:13 -0000 X-SWARE-Spam-Status: No, hits=-2.5 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 09 Nov 2009 17:42:10 +0000 Received: from int-mx08.intmail.prod.int.phx2.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id nA9HfQod009575; Mon, 9 Nov 2009 12:41:26 -0500 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx08.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id nA9HfPAB010852; Mon, 9 Nov 2009 12:41:25 -0500 Received: from opsy.redhat.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id nA9HfOFn008675; Mon, 9 Nov 2009 12:41:24 -0500 Received: by opsy.redhat.com (Postfix, from userid 500) id 355BA37815E; Mon, 9 Nov 2009 10:41:24 -0700 (MST) From: Tom Tromey To: Joel Brobecker Cc: Jon Beniston , gdb-patches@sourceware.org Subject: Re: [PATCH] Don't split executable paths with spaces in into multiple arguments References: <003c01ca5d52$1715da50$45418ef0$@com> <20091104161727.GH4557@adacore.com> Reply-To: tromey@redhat.com Date: Mon, 09 Nov 2009 17:42:00 -0000 In-Reply-To: <20091104161727.GH4557@adacore.com> (Joel Brobecker's message of "Wed, 4 Nov 2009 08:17:27 -0800") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-11/txt/msg00146.txt.bz2 >>>>> "Joel" == Joel Brobecker writes: >> gdb/ >> 2009-11-04 Jon Beniston >> * remote-sim.c(gdbsim_create_inferior) Quote executable path in case >> it >> contains spaces. Joel> OK. This is not handling the case where the filename contains a double Joel> quote, but it is not making things worse, and double-quotes in filenames Joel> are probably extremely rare. It seems to me that it would not be significantly harder for the code to do the correct thing in all cases. Tom