From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 24430 invoked by alias); 25 Feb 2010 18:34:01 -0000 Received: (qmail 24262 invoked by uid 22791); 25 Feb 2010 18:34:00 -0000 X-SWARE-Spam-Status: No, hits=-6.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 25 Feb 2010 18:33:56 +0000 Received: from int-mx08.intmail.prod.int.phx2.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o1PIXsnq030632 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Thu, 25 Feb 2010 13:33:54 -0500 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx08.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id o1PIXrQA006312; Thu, 25 Feb 2010 13:33:54 -0500 Received: from opsy.redhat.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id o1PIXnMZ002236; Thu, 25 Feb 2010 13:33:50 -0500 Received: by opsy.redhat.com (Postfix, from userid 500) id 721D8378261; Thu, 25 Feb 2010 11:33:49 -0700 (MST) From: Tom Tromey To: Phil Muldoon Cc: gdb-patches@sourceware.org Subject: Re: [python][patch] Fix 11036 References: <20100225142823.GA10175@localhost.localdomain> Reply-To: tromey@redhat.com Date: Thu, 25 Feb 2010 18:34:00 -0000 In-Reply-To: <20100225142823.GA10175@localhost.localdomain> (Phil Muldoon's message of "Thu, 25 Feb 2010 14:28:50 +0000") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-02/txt/msg00628.txt.bz2 >>>>> "Phil" == Phil Muldoon writes: Phil> 2010-02-25 Phil Muldoon Phil> PR python/11036 Phil> * python/py-frame.c (frapy_read_var): Add block argument and logic Phil> to cope with user provided blocks. Phil> + argument must be an instance of gdb.Block. Returns None if GDB Phil> + can't find the specified variable. */ This last sentence in this comment seems to be wrong. Sometimes the function returns None, sometimes it throws an exception. I think the function should behave more predictably somehow. Phil> + block = block_object_to_block (block_obj); Phil> + if (block == NULL) Phil> + return NULL; When block_object_to_block returns NULL, it does not set the Python exception. That makes this code erroneous. In other respects the code bits seem reasonable to me. Tom