From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 29576 invoked by alias); 13 Apr 2010 23:29:23 -0000 Received: (qmail 29568 invoked by uid 22791); 13 Apr 2010 23:29:22 -0000 X-SWARE-Spam-Status: No, hits=-6.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 13 Apr 2010 23:29:15 +0000 Received: from int-mx03.intmail.prod.int.phx2.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.16]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o3DNSlu7029651 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Tue, 13 Apr 2010 19:28:47 -0400 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx03.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id o3DNSkoQ005182; Tue, 13 Apr 2010 19:28:46 -0400 Received: from opsy.redhat.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id o3DNSjgB010340; Tue, 13 Apr 2010 19:28:46 -0400 Received: by opsy.redhat.com (Postfix, from userid 500) id 41F1E378887; Tue, 13 Apr 2010 17:28:45 -0600 (MDT) From: Tom Tromey To: crquan@gmail.com Cc: gdb-patches@sourceware.org, Hui Zhu , Joel Brobecker , Eli Zaretskii Subject: Re: [PATCH] disassemble support start,+length format References: <1270933267-14720-1-git-send-email-crquan@gmail.com> Reply-To: tromey@redhat.com Date: Tue, 13 Apr 2010 23:29:00 -0000 In-Reply-To: <1270933267-14720-1-git-send-email-crquan@gmail.com> (crquan@gmail.com's message of "Sun, 11 Apr 2010 05:01:07 +0800") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-04/txt/msg00436.txt.bz2 >>>>> ">" == Cheng Renquan writes: >> { >> /* Two arguments. */ >> + int incl_flag = 0; >> low = pc; >> + if (arg[0] == '+') >> + { This still looks wrong. The brace should be 2 spaces in from the 'if'. Also this doesn't skip whitespace before the '+'. Tom