From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-72393-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 9428 invoked by alias); 21 Apr 2010 22:27:44 -0000
Received: (qmail 9413 invoked by uid 22791); 21 Apr 2010 22:27:43 -0000
X-SWARE-Spam-Status: No, hits=-6.9 required=5.0 	tests=BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD
X-Spam-Check-By: sourceware.org
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28)     by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 21 Apr 2010 22:27:37 +0000
Received: from int-mx05.intmail.prod.int.phx2.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.18]) 	by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o3LMRZUF021450 	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) 	for <gdb-patches@sourceware.org>; Wed, 21 Apr 2010 18:27:35 -0400
Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) 	by int-mx05.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id o3LMRXbM007590; 	Wed, 21 Apr 2010 18:27:34 -0400
Received: from opsy.redhat.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) 	by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id o3LMRWRH025169; 	Wed, 21 Apr 2010 18:27:33 -0400
Received: by opsy.redhat.com (Postfix, from userid 500) 	id 9189737817D; Wed, 21 Apr 2010 16:27:32 -0600 (MDT)
From: Tom Tromey <tromey@redhat.com>
To: Chris Moller <cmoller@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: PR10179, Add support to set a breakpoint at every function in  a file
References: <4BCDFEA5.9090501@redhat.com> <m3d3xtgb95.fsf@fleche.redhat.com> 	<4BCE694E.9060101@redhat.com>
Reply-To: tromey@redhat.com
Date: Wed, 21 Apr 2010 22:27:00 -0000
In-Reply-To: <4BCE694E.9060101@redhat.com> (Chris Moller's message of "Tue, 20 	Apr 2010 22:56:14 -0400")
Message-ID: <m31ve8a1bf.fsf@fleche.redhat.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2010-04/txt/msg00712.txt.bz2

>>>>> "Chris" == Chris Moller <cmoller@redhat.com> writes:

Chris> +	  char * file_name;

Extra space.

Chris> +	* refcard.tex (Breakpoints and Watchpoints): Added brief
Chris> +	description of ilename-qualified rbreak.

Typo in "filename".

Chris> +specified file.  This can be used, for example, to set breakponts on

Typo in "breakpoints".

The doc changes look ok to me, but please wait for a review from Eli.

thanks,
Tom