Re: [patch 1/3] Make obconcat use stdarg

Mark Kettenis
2010-05-04T21:03:24Z

> From: Pedro Alves <pedro@codesourcery.com>
> Date: Mon, 3 May 2010 22:00:14 +0100
>
> On Monday 03 May 2010 21:19:05, Mark Kettenis wrote:
> > ok?
>
> Yes, of course.
>
> > 2010-05-03 Mark Kettenis <kettenis@faure.sibelius.xs4all.nl>
> >
> > * remote.c (register_remote_support_xml)
> > (remote_query_supported_append, remote_query_supported): Add cast
> > to NULL used as sentinel.
> > * tracepoint.c (tvariables_info_1): Likewise.
> > * utils.c (add_internal_problem_command): Likewise.
>
>
> > + remote_support_xml = concat ("xmlRegisters=", xml, (char *)NULL);
>
> It's way more common in our code base to put a space between cast
> and "castee" (would be `(char *) NULL' in this case). Not a big
> deal though.

I added the missing spaces and committed the diff. Thanks!