Re: [patch 1/3] Make obconcat use stdarg

Mark Kettenis
2010-05-07T14:44:58Z

> Date: Fri, 7 May 2010 16:31:03 +0200
> From: Jan Kratochvil <jan.kratochvil@redhat.com>
>
> On Tue, 04 May 2010 23:01:33 +0200, Mark Kettenis wrote:
> > > On Monday 03 May 2010 21:19:05, Mark Kettenis wrote:
> > > > 2010-05-03 Mark Kettenis <kettenis@faure.sibelius.xs4all.nl>
> > > >
> > > > * remote.c (register_remote_support_xml)
> > > > (remote_query_supported_append, remote_query_supported): Add cast
> > > > to NULL used as sentinel.
> > > > * tracepoint.c (tvariables_info_1): Likewise.
> > > > * utils.c (add_internal_problem_command): Likewise.
> [...]
> > I added the missing spaces and committed the diff. Thanks!
>
> Assuming this remaining one is OK to check-in.

Sure! Didn't hit that one on OpenBSD for obvious reasons ;).

> gdb/
> 2010-05-07 Jan Kratochvil <jan.kratochvil@redhat.com>
>
> * fbsd-nat.c (fbsd_make_corefile_notes): Add cast to NULL used as
> sentinel.
>
> --- a/gdb/fbsd-nat.c
> +++ b/gdb/fbsd-nat.c
> @@ -208,7 +208,8 @@ fbsd_make_corefile_notes (bfd *obfd, int *note_size)
> char *psargs = xstrdup (fname);
>
> if (get_inferior_args ())
> - psargs = reconcat (psargs, psargs, " ", get_inferior_args (), NULL);
> + psargs = reconcat (psargs, psargs, " ", get_inferior_args (),
> + (char *) NULL);
>
> note_data = elfcore_write_prpsinfo (obfd, note_data, note_size,
> fname, psargs);
>