Re: [patch] ATTR_* -> ATTRIBUTE_* unification [Re: `sentinel' gcc-3.x/OpenBSD compat.]

Jan Kratochvil
2010-05-02T21:37:09Z

On Sun, 02 May 2010 17:33:14 +0200, Pedro Alves wrote:
> The GDB part looks fine to me. Want to commit it separatelly to the
> GDBserver bit?

Checked-in:
http://sourceware.org/ml/gdb-cvs/2010-05/msg00011.html

Reintroduced back cli-out.c:cli_field_fmt's attr-format you have dropped by
`cli-out.c cleanup' today.

> If you don't feel like fixing this, I'll fix it after your patch is in.

Yes, please. BTW I do not understand why gdb/gdbserver/ cannot use the common
infrastructure when even the doc states:
In fact, a system that can run `gdbserver' to connect to a remote GDB
could also run GDB locally!
I believe gdbserver/ provides less resources + features requiring code than
libiberty/ .

I will post some similar NORETURN + ATTR_NORETURN -> ATTRIBUTE_NORETURN.

Going to drop NORETURN as it is only for gcc < 2.7, ansidecl.h does not
support it and a missing noreturn flag can only affect code size, performance
and affect compilation diagnostics.

Thanks,
Jan