Re: [patch] ATTR_NORETURN -> ATTRIBUTE_NORETURN unification [Re: [patch] ATTR_* -> ATTRIBUTE_* unification]

Pedro Alves
2010-05-02T23:42:05Z

On Monday 03 May 2010 00:19:41, Jan Kratochvil wrote:
> On Sun, 02 May 2010 23:36:36 +0200, Jan Kratochvil wrote:
> > I will post some similar NORETURN + ATTR_NORETURN -> ATTRIBUTE_NORETURN.
> >
> > Going to drop NORETURN as it is only for gcc < 2.7, ansidecl.h does not
> > support it and a missing noreturn flag can only affect code size, performance
> > and affect compilation diagnostics.
>
> error_no_arg was present both in command.h and cli/cli-cmds.h. Moving it the
> other way would require #include changes.
>
> mips_error will start to be effectively declared as noreturn.
>
> No regressions on {x86_64,x86_64-m32,i686}-fedora12-linux-gnu.
>

This is okay. Thanks for doing this.

> Similar work is needed in gdb/gdbserver/.
>
> doc/ talks about .mh files; but when similar macros are already used from
> include/ for bfd/ etc. it probably was inappropriate to do from .mh.

Yeah.

--
Pedro Alves