Re: [patch 1/3] Make obconcat use stdarg

Jan Kratochvil
2010-05-02T07:52:32Z

On Fri, 30 Apr 2010 21:08:48 +0200, Mark Kettenis wrote:
> I'm afraid you'll need an explicit cast for the NULLs used as the
> sentinel value

There is also needed a fix for cases already protected by ATTRIBUTE_SENTINEL
and already using just the bare "NULL" sentinel:

concat reconcat concat_length concat_copy concat_copy2

fbsd-nat.c by Mark Kettenis 50e330a0 2004-09-19
(reconcat has ATTRIBUTE_SENTINEL since bf7628f0 2004-09-05)
psargs = reconcat (psargs, psargs, " ", get_inferior_args (), NULL);
remote.c [HAVE_LIBEXPAT]
remote_support_xml = concat ("xmlRegisters=", xml, NULL);
p = concat (remote_support_xml, ",", xml, NULL);
remote.c d5ea7042 2010-03-30
char *p = concat (msg, ";", append, NULL);
char *p = concat ("qSupported:", q, NULL);
name = concat ("$", tsv->name, NULL);
utils.c 8b58bcf2 2009-01-26
concat ("maintenance set ", problem->name, " ", NULL),
concat ("maintenance show ", problem->name, " ", NULL),

Nobody has noticed this problem since 2004.

> , otherwise platforms that
>
> #define NULL 0L

So DJGPP is not such platform, which other platforms? FreeBSD apparently also
does not have this problem.

Thanks,
Jan