From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 13536 invoked by alias); 3 May 2010 18:25:06 -0000 Received: (qmail 13485 invoked by uid 22791); 3 May 2010 18:25:04 -0000 X-SWARE-Spam-Status: No, hits=-6.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 03 May 2010 18:24:58 +0000 Received: from int-mx04.intmail.prod.int.phx2.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.17]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o43IOvEZ002208 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Mon, 3 May 2010 14:24:57 -0400 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx04.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id o43IOuQP022951; Mon, 3 May 2010 14:24:57 -0400 Received: from opsy.redhat.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id o43IOtNF012007; Mon, 3 May 2010 14:24:56 -0400 Received: by opsy.redhat.com (Postfix, from userid 500) id 97CFC378183; Mon, 3 May 2010 12:24:55 -0600 (MDT) From: Tom Tromey To: Jan Kratochvil Cc: Mark Kettenis , gdb-patches@sourceware.org Subject: Re: [patch 1/3] Make obconcat use stdarg References: <20100430181605.GA19190@host0.dyn.jankratochvil.net> <201004301908.o3UJ8mGf006742@glazunov.sibelius.xs4all.nl> <20100502075217.GA29039@host0.dyn.jankratochvil.net> Reply-To: tromey@redhat.com Date: Mon, 03 May 2010 18:25:00 -0000 In-Reply-To: <20100502075217.GA29039@host0.dyn.jankratochvil.net> (Jan Kratochvil's message of "Sun, 2 May 2010 09:52:17 +0200") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-05/txt/msg00044.txt.bz2 >>>>> "Jan" == Jan Kratochvil writes: Jan> On Fri, 30 Apr 2010 21:08:48 +0200, Mark Kettenis wrote: >> I'm afraid you'll need an explicit cast for the NULLs used as the >> sentinel value Jan> There is also needed a fix for cases already protected by Jan> ATTRIBUTE_SENTINEL and already using just the bare "NULL" sentinel: Yes. Jan> Nobody has noticed this problem since 2004. Lucky, I guess. Elsewhere gdb uses `(char *) 0': ./ser-pipe.c: execl ("/bin/sh", "sh", "-c", name, (char *) 0); I am ok with that, or `(char *) NULL' or even `#define SENTINEL ...'. I realize this is ugly, but that's C for you. This problem has really bitten people in the past, it pays to be pedantically correct here. Tom