From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 16855 invoked by alias); 7 May 2010 17:42:51 -0000 Received: (qmail 16845 invoked by uid 22791); 7 May 2010 17:42:50 -0000 X-SWARE-Spam-Status: No, hits=-5.7 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 07 May 2010 17:42:45 +0000 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o47Hgcc4030417 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Fri, 7 May 2010 13:42:38 -0400 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id o47Hgcc9006636; Fri, 7 May 2010 13:42:38 -0400 Received: from opsy.redhat.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id o47HgbkH016819; Fri, 7 May 2010 13:42:37 -0400 Received: by opsy.redhat.com (Postfix, from userid 500) id 01409378183; Fri, 7 May 2010 11:42:36 -0600 (MDT) From: Tom Tromey To: Michael Snyder Cc: Pedro Alves , "gdb-patches\@sourceware.org" Subject: Re: [ob] remote.c, eliminate unused variables References: <4BE1D93F.8000309@vmware.com> <201005052151.19745.pedro@codesourcery.com> <4BE1DFA9.9060607@vmware.com> <201005052241.14753.pedro@codesourcery.com> <4BE1EF9C.8070807@vmware.com> Reply-To: tromey@redhat.com Date: Fri, 07 May 2010 17:42:00 -0000 In-Reply-To: <4BE1EF9C.8070807@vmware.com> (Michael Snyder's message of "Wed, 05 May 2010 15:22:20 -0700") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-05/txt/msg00190.txt.bz2 >>>>> "Michael" == Michael Snyder writes: Michael> No, I'm attempting to make the code easier to understand by Michael> removing dead code and variables. Since this warning is Michael> turned off, I'm not even reducing the number of warnings. Are you planning to enable them? I hope so, since otherwise this work will quickly regress. FWIW I read through all the patches and sent comments about the changes I saw that seemed fishy. Tom