Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Tom Tromey <tromey@redhat.com>
To: Jan Kratochvil <jan.kratochvil@redhat.com>
Cc: gdb-patches@sourceware.org, Sami Wagiaalla <swagiaal@redhat.com>
Subject: Re: [patch 1/2] Search typedefs in namespaces also in other files
Date: Mon, 28 Jun 2010 17:52:00 -0000	[thread overview]
Message-ID: <m31vbryrh0.fsf@fleche.redhat.com> (raw)
In-Reply-To: <20100625212859.GA14185@host0.dyn.jankratochvil.net> (Jan	Kratochvil's message of "Fri, 25 Jun 2010 23:28:59 +0200")

>>>>> "Jan" == Jan Kratochvil <jan.kratochvil@redhat.com> writes:

Tom> I think you should leave that comment in the previous function and write
Tom> a new comment for lookup_static_symbol_aux.

Jan> Made some change.  I find "comment in the previous function"
Jan> describes internals (="Do the symtabs first, then check the
Jan> psymtabs.") of the function being called.  Such comment should not
Jan> be at the caller, should be?

I don't totally follow, but I suppose the ideal is for a comment to
describe what the function does and also relevant info about its
arguments and returns; and not describe exactly how the function may do
its job.

I think what you did here is fine.

Tom


  parent reply	other threads:[~2010-06-28 17:52 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-06-14 15:59 Jan Kratochvil
2010-06-16 21:30 ` Tom Tromey
2010-06-25 21:29   ` Jan Kratochvil
2010-06-25 21:53     ` Jan Kratochvil
2010-06-26  8:06     ` Jan Kratochvil
2010-06-28 17:53       ` Tom Tromey
2010-06-28 17:52     ` Tom Tromey [this message]
2010-06-28 20:41       ` Jan Kratochvil

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m31vbryrh0.fsf@fleche.redhat.com \
    --to=tromey@redhat.com \
    --cc=gdb-patches@sourceware.org \
    --cc=jan.kratochvil@redhat.com \
    --cc=swagiaal@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox